qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/6] migration: Factor out checks for advised and listenin


From: David Hildenbrand
Subject: Re: [PATCH v3 3/6] migration: Factor out checks for advised and listening incomming postcopy
Date: Mon, 9 Jan 2023 15:39:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

On 05.01.23 18:18, Peter Xu wrote:
On Thu, Dec 22, 2022 at 12:02:12PM +0100, David Hildenbrand wrote:
+bool migration_incoming_postcopy_listening(void)
+{
+    PostcopyState ps = postcopy_state_get();
+
+    return ps >= POSTCOPY_INCOMING_LISTENING && ps < POSTCOPY_INCOMING_END;
+}

This name is misleading, IMHO.

The code means "we passed listening phase" but the name implies "we're
listening".  We can add the "incoming" into that if we want, though.


Let me call that migration_incoming_postcopy_running(). Thanks!

--
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]