Re: [PATCH v2 for-8.0 3/5] scripts/make-release: Remove CI yaml and more git files from the tarball

[Alex Bennée]

Thomas Huth <thuth@redhat.com> writes:

> These files are of no use in a normal tarball and thus should not
> be included here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  scripts/make-release | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/make-release b/scripts/make-release
> index 44a9d86a04..febeb6cb36 100755
> --- a/scripts/make-release
> +++ b/scripts/make-release
> @@ -41,6 +41,9 @@ git submodule update --init --single-branch
>          BaseTools/Source/C/BrotliCompress/brotli \
>          CryptoPkg/Library/OpensslLib/openssl \
>          MdeModulePkg/Library/BrotliCustomDecompressLib/brotli)
> +
> +rm -v .*.yml

Why remove them instead of excluding them like you do for .git* bellow.

>  popd
> -tar --exclude=.git -cjf ${destination}.tar.bz2 ${destination}
> +
> +tar --exclude=".git*" -cjf ${destination}.tar.bz2 ${destination}

In fact you could probably instead use a file (release.exclude?) and put
all those patterns in there?

>  rm -rf ${destination}


-- 
Alex Bennée