[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings |
Date: |
Sun, 27 Nov 2022 13:06:52 -0500 |
On Sat, 26 Nov 2022 at 10:25, Stefan Weil <sw@weilnetz.de> wrote:
>
> This fix is required for 32 bit hosts. The bug was detected by CI
> for arm-linux, but is also relevant for i386-linux.
>
> Reported-by: Stefan Hajnoczi <stefanha@gmail.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> subprojects/libvhost-user/libvhost-user.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>
> diff --git a/subprojects/libvhost-user/libvhost-user.c
> b/subprojects/libvhost-user/libvhost-user.c
> index d67953a1c3..80f9952e71 100644
> --- a/subprojects/libvhost-user/libvhost-user.c
> +++ b/subprojects/libvhost-user/libvhost-user.c
> @@ -651,7 +651,8 @@ generate_faults(VuDev *dev) {
>
> if (ioctl(dev->postcopy_ufd, UFFDIO_REGISTER, ®_struct)) {
> vu_panic(dev, "%s: Failed to userfault region %d "
> - "@%" PRIx64 " + size:%zx offset: %zx:
> (ufd=%d)%s\n",
> + "@%" PRIx64 " + size:%" PRIx64 " offset: %" PRIx64
> + ": (ufd=%d)%s\n",
> __func__, i,
> dev_region->mmap_addr,
> dev_region->size, dev_region->mmap_offset,
> --
> 2.35.1
>
- [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings, Stefan Weil, 2022/11/26
- [PATCH v3 for-7.2 2/6] libvhost-user: Fix format strings, Stefan Weil, 2022/11/26
- [PATCH v3 for-7.2 1/6] libvhost-user: Fix wrong type of argument to formatting function (reported by LGTM), Stefan Weil, 2022/11/26
- [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings, Stefan Weil, 2022/11/26
- Re: [PATCH v3 for-7.2 3/6] libvhost-user: Fix two more format strings,
Stefan Hajnoczi <=
- [PATCH v3 for-7.2 4/6] libvhost-user: Add format attribute to local function vu_panic, Stefan Weil, 2022/11/26
- [PATCH v3 for-7.2 5/6] MAINTAINERS: Add subprojects/libvhost-user to section "vhost", Stefan Weil, 2022/11/26
- [PATCH v3 for-7.2 6/6] Add G_GNUC_PRINTF to function qemu_set_info_str and fix related issues, Stefan Weil, 2022/11/26
- Re: [PATCH v3 for-7.2 0/6] Add format attributes and fix format strings, Stefan Hajnoczi, 2022/11/27