Re: [PATCH for-8.0 24/29] tcg/i386: Replace is64 with type in qemu_ld/st routines

[Philippe Mathieu-Daudé]

On 18/11/22 10:47, Richard Henderson wrote:
> Prepare for TCG_TYPE_I128 by not using a boolean.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   tcg/i386/tcg-target.c.inc | 54 ++++++++++++++++++++++++++-------------
>   1 file changed, 36 insertions(+), 18 deletions(-)


> @@ -2315,7 +2324,7 @@ static void tcg_out_qemu_st_direct(TCGContext *s, TCGReg 
> datalo, TCGReg datahi,
>       }
>   }
>   
> -static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, bool is64)
> +static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, TCGType type)
>   {
>       TCGReg datalo, datahi, addrlo;
>       TCGReg addrhi __attribute__((unused));
> @@ -2327,7 +2336,16 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg 
> *args, bool is64)

Confusing git-diff context :)

>   #endif
>   
>       datalo = *args++;
> -    datahi = (TCG_TARGET_REG_BITS == 32 && is64 ? *args++ : 0);
> +    switch (type) {
> +    case TCG_TYPE_I32:
> +        datahi = 0;
> +        break;
> +    case TCG_TYPE_I64:
> +        datahi = (TCG_TARGET_REG_BITS == 32 ? *args++ : 0);
> +        break;
> +    default:
> +        g_assert_not_reached();
> +    }

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>