[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/10] Run docker probe only if docker or podman are available
From: |
Alex Bennée |
Subject: |
[PULL 01/10] Run docker probe only if docker or podman are available |
Date: |
Tue, 15 Nov 2022 13:34:30 +0000 |
From: Stefan Weil <sw@weilnetz.de>
The docker probe uses "sudo -n" which can cause an e-mail with a security
warning
each time when configure is run. Therefore run docker probe only if either
docker
or podman are available.
That avoids the problematic "sudo -n" on build environments which have neither
docker nor podman installed.
Fixes: c4575b59155e2e00 ("configure: store container engine in config-host.mak")
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Message-Id: <20221030083510.310584-1-sw@weilnetz.de>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20221111145529.4020801-2-alex.bennee@linaro.org>
diff --git a/configure b/configure
index 66928692b0..26c7bc5154 100755
--- a/configure
+++ b/configure
@@ -1780,7 +1780,7 @@ fi
# functions to probe cross compilers
container="no"
-if test $use_containers = "yes"; then
+if test $use_containers = "yes" && (has "docker" || has "podman"); then
case $($python "$source_path"/tests/docker/docker.py probe) in
*docker) container=docker ;;
podman) container=podman ;;
--
2.34.1
- [PULL for 7.2 00/10] testing and doc updates, Alex Bennée, 2022/11/15
- [PULL 06/10] docs/devel: make language a little less code centric, Alex Bennée, 2022/11/15
- [PULL 02/10] tests/avocado: improve behaviour waiting for login prompts, Alex Bennée, 2022/11/15
- [PULL 04/10] tests/docker: allow user to override check target, Alex Bennée, 2022/11/15
- [PULL 09/10] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg, Alex Bennée, 2022/11/15
- [PULL 10/10] gitlab: integrate coverage report, Alex Bennée, 2022/11/15
- [PULL 05/10] docs/devel: add a maintainers section to development process, Alex Bennée, 2022/11/15
- [PULL 07/10] docs/devel: simplify the minimal checklist, Alex Bennée, 2022/11/15
- [PULL 08/10] docs/devel: try and improve the language around patch review, Alex Bennée, 2022/11/15
- [PULL 01/10] Run docker probe only if docker or podman are available,
Alex Bennée <=
- [PULL 03/10] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests, Alex Bennée, 2022/11/15
- Re: [PULL for 7.2 00/10] testing and doc updates, Stefan Hajnoczi, 2022/11/15