[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v4 37/83] virtio-net: introduce flush_or_purge_queued_packets()
From: |
Michael S. Tsirkin |
Subject: |
[PULL v4 37/83] virtio-net: introduce flush_or_purge_queued_packets() |
Date: |
Mon, 7 Nov 2022 17:50:33 -0500 |
From: Kangjie Xu <kangjie.xu@linux.alibaba.com>
Introduce the fucntion flush_or_purge_queued_packets(), it will be
used in device reset and virtqueue reset. Therefore, we extract the
common logic as a new function.
Signed-off-by: Kangjie Xu <kangjie.xu@linux.alibaba.com>
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Acked-by: Jason Wang <jasowang@redhat.com>
Message-Id: <20221017092558.111082-12-xuanzhuo@linux.alibaba.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/net/virtio-net.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index b6903aea54..038a6fba7c 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -124,6 +124,16 @@ static int vq2q(int queue_index)
return queue_index / 2;
}
+static void flush_or_purge_queued_packets(NetClientState *nc)
+{
+ if (!nc->peer) {
+ return;
+ }
+
+ qemu_flush_or_purge_queued_packets(nc->peer, true);
+ assert(!virtio_net_get_subqueue(nc)->async_tx.elem);
+}
+
/* TODO
* - we could suppress RX interrupt if we were so inclined.
*/
@@ -566,12 +576,7 @@ static void virtio_net_reset(VirtIODevice *vdev)
/* Flush any async TX */
for (i = 0; i < n->max_queue_pairs; i++) {
- NetClientState *nc = qemu_get_subqueue(n->nic, i);
-
- if (nc->peer) {
- qemu_flush_or_purge_queued_packets(nc->peer, true);
- assert(!virtio_net_get_subqueue(nc)->async_tx.elem);
- }
+ flush_or_purge_queued_packets(qemu_get_subqueue(n->nic, i));
}
}
--
MST
- Re: [PULL v4 30/83] virtio: core: vq reset feature negotation support, (continued)
[PULL v4 31/83] virtio-pci: support queue reset, Michael S. Tsirkin, 2022/11/07
[PULL v4 33/83] vhost: expose vhost_virtqueue_start(), Michael S. Tsirkin, 2022/11/07
[PULL v4 32/83] virtio-pci: support queue enable, Michael S. Tsirkin, 2022/11/07
[PULL v4 34/83] vhost: expose vhost_virtqueue_stop(), Michael S. Tsirkin, 2022/11/07
[PULL v4 35/83] vhost-net: vhost-kernel: introduce vhost_net_virtqueue_reset(), Michael S. Tsirkin, 2022/11/07
[PULL v4 36/83] vhost-net: vhost-kernel: introduce vhost_net_virtqueue_restart(), Michael S. Tsirkin, 2022/11/07
[PULL v4 38/83] virtio-net: support queue reset, Michael S. Tsirkin, 2022/11/07
[PULL v4 39/83] virtio-net: support queue_enable, Michael S. Tsirkin, 2022/11/07
[PULL v4 37/83] virtio-net: introduce flush_or_purge_queued_packets(),
Michael S. Tsirkin <=
[PULL v4 40/83] vhost: vhost-kernel: enable vq reset feature, Michael S. Tsirkin, 2022/11/07
[PULL v4 41/83] virtio-net: enable vq reset feature, Michael S. Tsirkin, 2022/11/07
[PULL v4 43/83] vhost-user: Fix out of order vring host notification handling, Michael S. Tsirkin, 2022/11/07
[PULL v4 42/83] virtio-rng-pci: Allow setting nvectors, so we can use MSI-X, Michael S. Tsirkin, 2022/11/07
[PULL v4 44/83] acpi: pc: vga: use AcpiDevAmlIf interface to build VGA device descriptors, Michael S. Tsirkin, 2022/11/07