qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] disas/nanomips: Fix invalid PRIx64 format calling img_fo


From: Stefan Weil
Subject: Re: [PATCH 2/5] disas/nanomips: Fix invalid PRIx64 format calling img_format()
Date: Tue, 1 Nov 2022 13:10:12 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0

Am 01.11.22 um 12:44 schrieb Philippe Mathieu-Daudé:

Fix:

   disas/nanomips.c:12231:62: warning: format specifies type 'char *' but the 
argument has type 'uint64' (aka 'unsigned long long') [-Wformat]
     return img_format("RESTOREF 0x%" PRIx64 ", %s", u_value, count_value);
                                                ~~            ^~~~~~~~~~~
                                                %llu

Fixes: 4066c152b3 ("disas/nanomips: Remove IMMEDIATE functions")
Reported-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
  disas/nanomips.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/disas/nanomips.c b/disas/nanomips.c
index 6466c80dc5..e4b21e7c45 100644
--- a/disas/nanomips.c
+++ b/disas/nanomips.c
@@ -12235,7 +12235,8 @@ static char *RESTOREF(uint64 instruction, Dis_info 
*info)
      uint64 u_value = extract_u_11_10_9_8_7_6_5_4_3__s3(instruction);
- return img_format("RESTOREF 0x%" PRIx64 ", %s", u_value, count_value);
+    return img_format("RESTOREF 0x%" PRIx64 ", 0x%" PRIx64,
+                      u_value, count_value);
  }


Reviewed-by: Stefan Weil <sw@weilnetz.de>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]