Re: [PATCH 1/3] tcg/sparc: Remove support for sparc32plus

[Peter Maydell]

On Mon, 17 Oct 2022 at 07:44, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Since 9b9c37c36439, we have only supported sparc64 cpus.
> Debian and Gentoo now only support 64-bit sparc64 userland,
> so it is time to drop the 32-bit sparc64 userland: sparc32plus.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/sparc/tcg-target.h     |  11 ---
>  tcg/tcg.c                  |  75 +----------------
>  tcg/sparc/tcg-target.c.inc | 166 +++++++------------------------------
>  3 files changed, 33 insertions(+), 219 deletions(-)
>
> diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h
> index c050763049..8655acdbe5 100644
> --- a/tcg/sparc/tcg-target.h
> +++ b/tcg/sparc/tcg-target.h
> @@ -25,8 +25,6 @@
>  #ifndef SPARC_TCG_TARGET_H
>  #define SPARC_TCG_TARGET_H
>
> -#define TCG_TARGET_REG_BITS 64

Why do we delete this?


> diff --git a/tcg/sparc/tcg-target.c.inc b/tcg/sparc/tcg-target.c.inc
> index 72d9552fd0..097bcfcd12 100644
> --- a/tcg/sparc/tcg-target.c.inc
> +++ b/tcg/sparc/tcg-target.c.inc
> @@ -22,6 +22,11 @@
>   * THE SOFTWARE.
>   */
>
> +/* We only support generating code for 64-bit mode.  */
> +#ifndef __arch64__
> +#error "unsupported code generation mode"

We might as well be more specific:
"no support for generating code for 32-bit SPARC"
(though I guess that configure ought in theory to prevent us getting here
in that situation ?)

Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM