Re: [PATCH] avocado: use sha1 for fc31 imgs to avoid first time re-download

[Daniel P . Berrangé]

On Sat, Oct 22, 2022 at 02:03:50PM -0300, Daniel Henrique Barboza wrote:
> 'make check-avocado' will download any images that aren't present in the
> cache via 'get-vm-images' in tests/Makefile.include. The target that
> downloads fedora 31 images, get-vm-image-fedora-31, will use 'avocado
> vmimage get  --distro=fedora --distro-version=31 --arch=(...)' to
> download the image for each arch. Note that this command does not
> support any argument to set the hash algorithm used and, based on the
> avocado source code [1], DEFAULT_HASH_ALGORITHM is set to "sha1". The
> sha1 hash is stored in a Fedora-Cloud-Base-31-1.9.{ARCH}.qcow2-CHECKSUM
> in the cache.

> For now, in QEMU, let's use sha1 for all Fedora 31 images. This will
> immediately spares us at least one extra download for each Fedora 31
> image that we're doing in all our CI runs.
> 
> [1] https://github.com/avocado-framework/avocado.git @ 942a5d6972906
> [2] https://github.com/avocado-framework/avocado/issues/5496

Can we just ask Avocado maintainers to fix this problem on their
side to allow use of a modern hash alg as a priority item. We've
already had this problem in QEMU for over a year AFAICT, so doesn't
seem like we need to urgently do a workaround on QEMU side, so we
can get Avocado devs to commit to fixing it in the next month.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|