[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v13 07/17] net: socket: Don't ignore EINVAL on netdev socket conn
From: |
Laurent Vivier |
Subject: |
[PATCH v13 07/17] net: socket: Don't ignore EINVAL on netdev socket connection |
Date: |
Thu, 20 Oct 2022 18:25:48 +0200 |
From: Stefano Brivio <sbrivio@redhat.com>
Other errors are treated as failure by net_socket_connect_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
net/socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index ade1ecf38b87..4944bb70d580 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *peer,
if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */
} else if (errno == EINPROGRESS ||
- errno == EALREADY ||
- errno == EINVAL) {
+ errno == EALREADY) {
break;
} else {
error_setg_errno(errp, errno, "can't connect socket");
--
2.37.3
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, (continued)
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Laurent Vivier, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Laurent Vivier, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Stefano Brivio, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/21
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/24
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Stefano Brivio, 2022/10/24
- Re: [PATCH v13 17/17] net: stream: add QAPI events to report connection state, Markus Armbruster, 2022/10/24
- [PATCH v13 07/17] net: socket: Don't ignore EINVAL on netdev socket connection,
Laurent Vivier <=
- [PATCH v13 05/17] net: introduce qemu_set_info_str() function, Laurent Vivier, 2022/10/20
- [PATCH v13 13/17] qemu-sockets: move and rename SocketAddress_to_str(), Laurent Vivier, 2022/10/20
- [PATCH v13 12/17] net: dgram: add unix socket, Laurent Vivier, 2022/10/20
- [PATCH v13 15/17] net: stream: move to QIO to enable additional parameters, Laurent Vivier, 2022/10/20
- [PATCH v13 16/17] tests/qtest: netdev: test stream and dgram backends, Laurent Vivier, 2022/10/20
- [PATCH v13 10/17] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/10/20
- [PATCH v13 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent, Laurent Vivier, 2022/10/20
- Re: [PATCH v13 00/17] qapi: net: add unix socket type support to netdev backend, Jason Wang, 2022/10/21