Re: [PATCH v5 05/10] acpi/tests/avocado/bits: add SPDX license identifiers for bios bits smilatency tests

[Ani Sinha]

On Thu, Oct 20, 2022 at 4:17 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Ani Sinha <ani@anisinha.ca> writes:
>
> > On Wed, Oct 19, 2022 at 9:02 PM Alex Bennée <alex.bennee@linaro.org> wrote:
> >>
> >>
> >> Ani Sinha <ani@anisinha.ca> writes:
> >>
> >> > Added the SPDX license identifier for smilatency tests.
> >> > Also added a comment indicating that smilatency test is run from within 
> >> > the
> >> > biosbits environment/VM and hence is not subjected to QEMU build/test
> >> > environment dependency fulfilments or QEMU maintanance activities.
> >> >
> >> > Cc: Daniel P. Berrangé <berrange@redhat.com>
> >> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> >> > Cc: Maydell Peter <peter.maydell@linaro.org>
> >> > Cc: John Snow <jsnow@redhat.com>
> >> > Cc: Thomas Huth <thuth@redhat.com>
> >> > Cc: Alex Bennée <alex.bennee@linaro.org>
> >> > Cc: Igor Mammedov <imammedo@redhat.com>
> >> > Cc: Michael Tsirkin <mst@redhat.com>
> >> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> >> > ---
> >> >  tests/avocado/acpi-bits/bits-tests/smilatency.py2 | 4 ++++
> >> >  1 file changed, 4 insertions(+)
> >>
> >> Thinking about this again, why not just merge this with the initial code
> >> dump?
> >
> > I wanted to keep the original test scripts untouched from bits and
> > make our changes in separate commits. That way it helps to understand
> > exactly what we added/modified in the original bits test script.
>
> That if fair enough as long as bisection isn't broken. Do the tests only
> get run at the end of the series?

Yes patch 8 is the actual avocado test that executes these bits tests
from within bits VM.