[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 02/53] configure: don't enable firmware for targets that are not b
From: |
Paolo Bonzini |
Subject: |
[PULL 02/53] configure: don't enable firmware for targets that are not built |
Date: |
Tue, 18 Oct 2022 15:29:51 +0200 |
This avoids the unfortunate effect of building pc-bios blobs
even for targets the user isn't interested in.
Due to the bi-arch nature of x86 and PPC firmware, check for the
desired target by hand, and don't just look for the compilation target
in $target_list.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
configure | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 45ee6f4eb3..f9ec050bf8 100755
--- a/configure
+++ b/configure
@@ -1841,6 +1841,16 @@ compute_target_variable() {
fi
}
+have_target() {
+ for i; do
+ case " $target_list " in
+ *" $i "*) return 0;;
+ *) ;;
+ esac
+ done
+ return 1
+}
+
# probe_target_compiler TARGET
#
# Look for a compiler for the given target, either native or cross.
@@ -2261,8 +2271,9 @@ echo "# Automatically generated by configure - do not
modify" > Makefile.prereqs
# Mac OS X ships with a broken assembler
roms=
-if test "$targetos" != "darwin" && test "$targetos" != "sunos" && \
- test "$targetos" != "haiku" && test "$softmmu" = yes && \
+if have_target i386-softmmu x86_64-softmmu && \
+ test "$targetos" != "darwin" && test "$targetos" != "sunos" && \
+ test "$targetos" != "haiku" && \
probe_target_compiler i386-softmmu; then
roms="pc-bios/optionrom"
config_mak=pc-bios/optionrom/config.mak
@@ -2271,7 +2282,8 @@ if test "$targetos" != "darwin" && test "$targetos" !=
"sunos" && \
write_target_makefile >> $config_mak
fi
-if test "$softmmu" = yes && probe_target_compiler ppc-softmmu; then
+if have_target ppc-softmmu ppc64-softmmu && \
+ probe_target_compiler ppc-softmmu; then
roms="$roms pc-bios/vof"
config_mak=pc-bios/vof/config.mak
echo "# Automatically generated by configure - do not modify" > $config_mak
@@ -2281,7 +2293,7 @@ fi
# Only build s390-ccw bios if the compiler has -march=z900 or -march=z10
# (which is the lowest architecture level that Clang supports)
-if test "$softmmu" = yes && probe_target_compiler s390x-softmmu; then
+if have_target s390x-softmmu && probe_target_compiler s390x-softmmu; then
write_c_skeleton
do_compiler "$target_cc" $target_cc_cflags -march=z900 -o $TMPO -c $TMPC
has_z900=$?
--
2.37.3
- [PULL 00/53] target/i386, scsi, build patches for 2022-10-18, Paolo Bonzini, 2022/10/18
- [PULL 01/53] virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events, Paolo Bonzini, 2022/10/18
- [PULL 02/53] configure: don't enable firmware for targets that are not built,
Paolo Bonzini <=
- [PULL 03/53] scsi: Use device_cold_reset() and bus_cold_reset(), Paolo Bonzini, 2022/10/18
- [PULL 05/53] hyperv: fix SynIC SINT assertion failure on guest reset, Paolo Bonzini, 2022/10/18
- [PULL 08/53] target/i386: Save and restore pc_save before tcg_remove_ops_after, Paolo Bonzini, 2022/10/18
- [PULL 07/53] target/i386: Use device_cold_reset() to reset the APIC, Paolo Bonzini, 2022/10/18
- [PULL 10/53] target/i386: Direct call get_hphys from mmu_translate, Paolo Bonzini, 2022/10/18
- [PULL 11/53] target/i386: Introduce structures for mmu_translate, Paolo Bonzini, 2022/10/18
- [PULL 06/53] configure: Avoid using strings binary, Paolo Bonzini, 2022/10/18
- [PULL 04/53] hw/scsi/vmw_pvscsi.c: Use device_cold_reset() to reset SCSI devices, Paolo Bonzini, 2022/10/18
- [PULL 09/53] target/i386: Use MMUAccessType across excp_helper.c, Paolo Bonzini, 2022/10/18
- [PULL 12/53] target/i386: Reorg GET_HPHYS, Paolo Bonzini, 2022/10/18