qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/4] qtest: Improve error messages when property can not be s


From: Thomas Huth
Subject: Re: [PATCH 3/4] qtest: Improve error messages when property can not be set right now
Date: Wed, 12 Oct 2022 20:05:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 12/10/2022 17.38, Markus Armbruster wrote:
When you try to set qtest property "log" while the qtest object is
active, the error message blames "insufficient permission":

     $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -chardev 
socket,id=chrqt0,path=qtest.socket,server=on,wait=off -object 
qtest,id=qt0,chardev=chrqt0,log=/dev/null
     QEMU 7.1.50 monitor - type 'help' for more information
     (qemu) qom-set /objects/qt0 log qtest.log
     Error: Insufficient permission to perform this operation

This implies it could work with "sufficient permission".  It can't.
Change the error message to:

     Error: Property 'log' can not be set now
Can it be set later? ... if not, that error message is almost as confusing 
as the original one. Maybe it's better to tell the users *when* they can set 
the property?
 Thomas





reply via email to

[Prev in Thread] Current Thread [Next in Thread]