[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 22/55] vhost-user-blk: make it possible to disable write-zeroes/di
From: |
Michael S. Tsirkin |
Subject: |
[PULL 22/55] vhost-user-blk: make it possible to disable write-zeroes/discard |
Date: |
Mon, 10 Oct 2022 13:30:15 -0400 |
From: Daniil Tatianin <d-tatianin@yandex-team.ru>
It is useful to have the ability to disable these features for
compatibility with older VMs that don't have these implemented.
Signed-off-by: Daniil Tatianin <d-tatianin@yandex-team.ru>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Message-Id: <20220906073111.353245-4-d-tatianin@yandex-team.ru>
Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/block/vhost-user-blk.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c
index 2bba42478d..92bfe56b45 100644
--- a/hw/block/vhost-user-blk.c
+++ b/hw/block/vhost-user-blk.c
@@ -259,8 +259,6 @@ static uint64_t vhost_user_blk_get_features(VirtIODevice
*vdev,
virtio_add_feature(&features, VIRTIO_BLK_F_BLK_SIZE);
virtio_add_feature(&features, VIRTIO_BLK_F_FLUSH);
virtio_add_feature(&features, VIRTIO_BLK_F_RO);
- virtio_add_feature(&features, VIRTIO_BLK_F_DISCARD);
- virtio_add_feature(&features, VIRTIO_BLK_F_WRITE_ZEROES);
if (s->config_wce) {
virtio_add_feature(&features, VIRTIO_BLK_F_CONFIG_WCE);
@@ -598,6 +596,10 @@ static Property vhost_user_blk_properties[] = {
VHOST_USER_BLK_AUTO_NUM_QUEUES),
DEFINE_PROP_UINT32("queue-size", VHostUserBlk, queue_size, 128),
DEFINE_PROP_BIT("config-wce", VHostUserBlk, config_wce, 0, true),
+ DEFINE_PROP_BIT64("discard", VHostUserBlk, parent_obj.host_features,
+ VIRTIO_BLK_F_DISCARD, true),
+ DEFINE_PROP_BIT64("write-zeroes", VHostUserBlk, parent_obj.host_features,
+ VIRTIO_BLK_F_WRITE_ZEROES, true),
DEFINE_PROP_END_OF_LIST(),
};
--
MST
- [PULL 12/55] tests/qtest: add a timeout for subprocess_run_one_test, (continued)
- [PULL 12/55] tests/qtest: add a timeout for subprocess_run_one_test, Michael S. Tsirkin, 2022/10/10
- [PULL 13/55] tests/qtest: use qos_printf instead of g_test_message, Michael S. Tsirkin, 2022/10/10
- [PULL 14/55] tests/qtest: catch unhandled vhost-user messages, Michael S. Tsirkin, 2022/10/10
- [PULL 15/55] tests/qtest: plain g_assert for VHOST_USER_F_PROTOCOL_FEATURES, Michael S. Tsirkin, 2022/10/10
- [PULL 16/55] tests/qtest: add assert to catch bad features, Michael S. Tsirkin, 2022/10/10
- [PULL 17/55] tests/qtest: implement stub for VHOST_USER_GET_CONFIG, Michael S. Tsirkin, 2022/10/10
- [PULL 18/55] tests/qtest: add a get_features op to vhost-user-test, Michael S. Tsirkin, 2022/10/10
- [PULL 19/55] tests/qtest: enable tests for virtio-gpio, Michael S. Tsirkin, 2022/10/10
- [PULL 20/55] virtio: introduce VirtIOConfigSizeParams & virtio_get_config_size, Michael S. Tsirkin, 2022/10/10
- [PULL 21/55] virtio-blk: move config size params to virtio-blk-common, Michael S. Tsirkin, 2022/10/10
- [PULL 22/55] vhost-user-blk: make it possible to disable write-zeroes/discard,
Michael S. Tsirkin <=
- [PULL 23/55] vhost-user-blk: make 'config_wce' part of 'host_features', Michael S. Tsirkin, 2022/10/10
- [PULL 24/55] vhost-user-blk: dynamically resize config space based on features, Michael S. Tsirkin, 2022/10/10
- [PULL 25/55] tests/acpi: virt: allow acpi GTDT changes, Michael S. Tsirkin, 2022/10/10
- [PULL 26/55] acpi: arm/virt: build_gtdt: fix invalid 64-bit physical addresses, Michael S. Tsirkin, 2022/10/10
- [PULL 27/55] tests/acpi: virt: update ACPI GTDT binaries, Michael S. Tsirkin, 2022/10/10
- [PULL 28/55] mem/cxl-type3: Add sn option to provide serial number for PCI ecap, Michael S. Tsirkin, 2022/10/10
- [PULL 29/55] Revert "intel_iommu: Fix irqchip / X2APIC configuration checks", Michael S. Tsirkin, 2022/10/10