[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/24] hcd-xhci: drop operation with secondary stream arrays enabl
From: |
Gerd Hoffmann |
Subject: |
[PULL 15/24] hcd-xhci: drop operation with secondary stream arrays enabled |
Date: |
Tue, 27 Sep 2022 10:19:03 +0200 |
From: Qiang Liu <cyruscyliu@gmail.com>
The abort() in xhci_find_stream() can be triggered via enabling the secondary
stream arrays by setting linear stream array (LSA) bit (in endpoint context) to
0. We may show warnings and drop this operation.
Fixes: 024426acc0a2 ("usb-xhci: usb3 streams")
Reported-by: Qiang Liu <cyruscyliu@gmail.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1192
Signed-off-by: Qiang Liu <cyruscyliu@gmail.com>
Message-Id: <20220904125926.2141607-1-cyruscyliu@gmail.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/hcd-xhci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index acd60b1a4904..8299f35e6695 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1020,7 +1020,9 @@ static XHCIStreamContext *xhci_find_stream(XHCIEPContext
*epctx,
}
sctx = epctx->pstreams + streamid;
} else {
- FIXME("secondary streams not implemented yet");
+ fprintf(stderr, "xhci: FIXME: secondary streams not implemented yet");
+ *cc_error = CC_INVALID_STREAM_TYPE_ERROR;
+ return NULL;
}
if (sctx->sct == -1) {
--
2.37.3
- [PULL 05/24] ui: add some vdagent related traces, (continued)
- [PULL 05/24] ui: add some vdagent related traces, Gerd Hoffmann, 2022/09/27
- [PULL 10/24] ui/console: fix three double frees in png_save(), Gerd Hoffmann, 2022/09/27
- [PULL 09/24] ui/vdagent: fix serial reset of guest agent, Gerd Hoffmann, 2022/09/27
- [PULL 03/24] Revert "main-loop: Disable block backend global state assertion on Cocoa", Gerd Hoffmann, 2022/09/27
- [PULL 02/24] ui/cocoa: Run qemu_init in the main thread, Gerd Hoffmann, 2022/09/27
- [PULL 06/24] ui/clipboard: fix serial priority, Gerd Hoffmann, 2022/09/27
- [PULL 11/24] hw/usb/hcd-xhci: Check whether DMA accesses fail, Gerd Hoffmann, 2022/09/27
- [PULL 04/24] meson: Allow to enable gtk and sdl while cocoa is enabled, Gerd Hoffmann, 2022/09/27
- [PULL 16/24] usbnet: Add missing usb_wakeup() call in usbnet_receive(), Gerd Hoffmann, 2022/09/27
- [PULL 14/24] usb/msd: add usb_msd_fatal_error() and fix guest-triggerable assert, Gerd Hoffmann, 2022/09/27
- [PULL 15/24] hcd-xhci: drop operation with secondary stream arrays enabled,
Gerd Hoffmann <=
- [PULL 12/24] hcd-ohci: Drop ohci_service_iso_td() if ed->head & OHCI_DPTR_MASK is zero, Gerd Hoffmann, 2022/09/27
- [PULL 13/24] usb/msd: move usb_msd_packet_complete(), Gerd Hoffmann, 2022/09/27
- [PULL 19/24] usbnet: Report link-up via interrupt endpoint in CDC-ECM mode, Gerd Hoffmann, 2022/09/27
- [PULL 18/24] usbnet: Detect short packets as sent by the xHCI controller, Gerd Hoffmann, 2022/09/27
- [PULL 17/24] usbnet: Accept mandatory USB_CDC_SET_ETHERNET_PACKET_FILTER request, Gerd Hoffmann, 2022/09/27
- [PULL 24/24] virtio-gpu: update scanout if there is any area covered by the rect, Gerd Hoffmann, 2022/09/27
- [PULL 21/24] Revert "audio: Log context for audio bug", Gerd Hoffmann, 2022/09/27
- [PULL 20/24] audio: Add sndio backend, Gerd Hoffmann, 2022/09/27
- [PULL 22/24] audio: remove abort() in audio_bug(), Gerd Hoffmann, 2022/09/27
- [PULL 23/24] hw/display/ati_2d: Fix buffer overflow in ati_2d_blt (CVE-2021-3638), Gerd Hoffmann, 2022/09/27