[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 09/14] s390x/pci: don't fence interpreted devices without MSI-X
From: |
Thomas Huth |
Subject: |
[PULL 09/14] s390x/pci: don't fence interpreted devices without MSI-X |
Date: |
Mon, 26 Sep 2022 19:07:59 +0200 |
From: Matthew Rosato <mjrosato@linux.ibm.com>
Lack of MSI-X support is not an issue for interpreted passthrough
devices, so let's let these in. This will allow, for example, ISM
devices to be passed through -- but only when interpretation is
available and being used.
Signed-off-by: Matthew Rosato <mjrosato@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Pierre Morel <pmorel@linux.ibm.com>
Message-Id: <20220902172737.170349-5-mjrosato@linux.ibm.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/s390x/s390-pci-bus.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 156051e6e9..816d17af99 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -881,6 +881,10 @@ static int s390_pci_msix_init(S390PCIBusDevice *pbdev)
static void s390_pci_msix_free(S390PCIBusDevice *pbdev)
{
+ if (pbdev->msix.entries == 0) {
+ return;
+ }
+
memory_region_del_subregion(&pbdev->iommu->mr, &pbdev->msix_notify_mr);
object_unparent(OBJECT(&pbdev->msix_notify_mr));
}
@@ -1093,7 +1097,7 @@ static void s390_pcihost_plug(HotplugHandler
*hotplug_dev, DeviceState *dev,
pbdev->interp = false;
}
- if (s390_pci_msix_init(pbdev)) {
+ if (s390_pci_msix_init(pbdev) && !pbdev->interp) {
error_setg(errp, "MSI-X support is mandatory "
"in the S390 architecture");
return;
--
2.31.1
- [PULL 00/14] s390x patches and slirp submodule removal, Thomas Huth, 2022/09/26
- [PULL 01/14] s390x/tcg: Fix opcode for lzrf, Thomas Huth, 2022/09/26
- [PULL 04/14] target/s390x: support PRNO_TRNG instruction, Thomas Huth, 2022/09/26
- [PULL 03/14] target/s390x: support SHA-512 extensions, Thomas Huth, 2022/09/26
- [PULL 05/14] configure: Add -Wno-gnu-variable-sized-type-not-at-end, Thomas Huth, 2022/09/26
- [PULL 02/14] linux-user/host/s390: Add vector instructions to host_signal_write(), Thomas Huth, 2022/09/26
- [PULL 09/14] s390x/pci: don't fence interpreted devices without MSI-X,
Thomas Huth <=
- [PULL 07/14] s390x/pci: add routine to get host function handle from CLP info, Thomas Huth, 2022/09/26
- [PULL 08/14] s390x/pci: enable for load/store interpretation, Thomas Huth, 2022/09/26
- [PULL 11/14] s390x/pci: let intercept devices have separate PCI groups, Thomas Huth, 2022/09/26
- [PULL 14/14] Remove the slirp submodule (i.e. compile only with an external libslirp), Thomas Huth, 2022/09/26
- [PULL 06/14] Update linux headers to v6.0-rc4, Thomas Huth, 2022/09/26
- [PULL 10/14] s390x/pci: enable adapter event notification for interpreted devices, Thomas Huth, 2022/09/26
- [PULL 12/14] s390x/pci: reflect proper maxstbl for groups of interpreted devices, Thomas Huth, 2022/09/26
- [PULL 13/14] s390x/s390-virtio-ccw: add zpcii-disable machine property, Thomas Huth, 2022/09/26
- Re: [PULL 00/14] s390x patches and slirp submodule removal, Stefan Hajnoczi, 2022/09/27