[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 48/54] io/channel-watch: Drop the unnecessary cast
From: |
Bin Meng |
Subject: |
[PATCH v3 48/54] io/channel-watch: Drop the unnecessary cast |
Date: |
Sun, 25 Sep 2022 19:30:26 +0800 |
From: Bin Meng <bin.meng@windriver.com>
There is no need to do a type cast on ssource->socket as it is
already declared as a SOCKET.
Suggested-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
(no changes since v2)
Changes in v2:
- new patch: "io/channel-watch: Drop the unnecessary cast"
io/channel-watch.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/io/channel-watch.c b/io/channel-watch.c
index 89f3c8a88a..43d38494f7 100644
--- a/io/channel-watch.c
+++ b/io/channel-watch.c
@@ -130,13 +130,13 @@ qio_channel_socket_source_check(GSource *source)
FD_ZERO(&wfds);
FD_ZERO(&xfds);
if (ssource->condition & G_IO_IN) {
- FD_SET((SOCKET)ssource->socket, &rfds);
+ FD_SET(ssource->socket, &rfds);
}
if (ssource->condition & G_IO_OUT) {
- FD_SET((SOCKET)ssource->socket, &wfds);
+ FD_SET(ssource->socket, &wfds);
}
if (ssource->condition & G_IO_PRI) {
- FD_SET((SOCKET)ssource->socket, &xfds);
+ FD_SET(ssource->socket, &xfds);
}
ssource->revents = 0;
if (select(0, &rfds, &wfds, &xfds, &tv0) == 0) {
--
2.34.1
- [PATCH v3 40/54] tests/qtest: ide-test: Open file in binary mode, (continued)
- [PATCH v3 40/54] tests/qtest: ide-test: Open file in binary mode, Bin Meng, 2022/09/25
- [PATCH v3 44/54] tests/qtest: microbit-test: Fix socket access for win32, Bin Meng, 2022/09/25
- [PATCH v3 38/54] tests/qtest: bios-tables-test: Adapt the case for win32, Bin Meng, 2022/09/25
- [PATCH v3 39/54] tests/qtest: migration-test: Disable IO redirection for win32, Bin Meng, 2022/09/25
- [PATCH v3 41/54] tests/qtest: virtio-net-failover: Disable migration tests for win32, Bin Meng, 2022/09/25
- [PATCH v3 43/54] tests/qtest: migration-test: Make sure QEMU process "to" exited after migration is canceled, Bin Meng, 2022/09/25
- [PATCH v3 37/54] tests/qtest: {ahci, ide}-test: Use relative path for temporary files for win32, Bin Meng, 2022/09/25
- [PATCH v3 48/54] io/channel-watch: Drop the unnecessary cast,
Bin Meng <=
- [PATCH v3 46/54] tests/qtest: libqtest: Correct the timeout unit of blocking receive calls for win32, Bin Meng, 2022/09/25
- [PATCH v3 49/54] io/channel-watch: Fix socket watch on Windows, Bin Meng, 2022/09/25
- [PATCH v3 45/54] tests/qtest: libqtest: Replace the call to close a socket with closesocket(), Bin Meng, 2022/09/25
- [PATCH v3 51/54] .gitlab-ci.d/windows.yml: Increase the timeout to 90 minutes, Bin Meng, 2022/09/25
- [PATCH v3 50/54] tests/qtest: migration-test: Skip running some TLS cases for win32, Bin Meng, 2022/09/25
- [PATCH v3 47/54] io/channel-watch: Drop a superfluous '#ifdef WIN32', Bin Meng, 2022/09/25
- [PATCH v3 53/54] tests/qtest: Enable qtest build on Windows, Bin Meng, 2022/09/25
- [PATCH v3 52/54] .gitlab-ci.d/windows.yml: Display meson test logs, Bin Meng, 2022/09/25
- [PATCH v3 54/54] docs/devel: testing: Document writing portable test cases, Bin Meng, 2022/09/25