[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 28/39] hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound acces
From: |
Bin Meng |
Subject: |
[PATCH v2 28/39] hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure |
Date: |
Tue, 20 Sep 2022 18:31:48 +0800 |
From: Xuzhou Cheng <xuzhou.cheng@windriver.com>
pnv_phb3_root_bus_info and pnv_phb4_root_bus_info are missing the
instance_size initialization. This results in accessing out-of-bound
memory when setting 'chip-id' and 'phb-id', and eventually crashes
glib's malloc functionality with the following message:
"qemu-system-ppc64: GLib: ../glib-2.72.3/glib/gmem.c:131: failed to allocate
3232 bytes"
This issue was noticed only when running qtests with QEMU Windows
32-bit executable. Windows 64-bit, Linux 32/64-bit do not expose
this bug though.
Fixes: 9ae1329ee2fe ("ppc/pnv: Add models for POWER8 PHB3 PCIe Host bridge")
Fixes: 4f9924c4d4cf ("ppc/pnv: Add models for POWER9 PHB4 PCIe Host bridge")
Signed-off-by: Xuzhou Cheng <xuzhou.cheng@windriver.com>
Signed-off-by: Bin Meng <bin.meng@windriver.com>
---
Changes in v2:
- new patch: "hw/pci-host: pnv_phb{3,4}: Fix heap out-of-bound access failure"
hw/pci-host/pnv_phb3.c | 1 +
hw/pci-host/pnv_phb4.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/hw/pci-host/pnv_phb3.c b/hw/pci-host/pnv_phb3.c
index af8575c007..9054c393a2 100644
--- a/hw/pci-host/pnv_phb3.c
+++ b/hw/pci-host/pnv_phb3.c
@@ -1169,6 +1169,7 @@ static void pnv_phb3_root_bus_class_init(ObjectClass
*klass, void *data)
static const TypeInfo pnv_phb3_root_bus_info = {
.name = TYPE_PNV_PHB3_ROOT_BUS,
.parent = TYPE_PCIE_BUS,
+ .instance_size = sizeof(PnvPHB3RootBus),
.class_init = pnv_phb3_root_bus_class_init,
};
diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
index 824e1a73fb..ccbde841fc 100644
--- a/hw/pci-host/pnv_phb4.c
+++ b/hw/pci-host/pnv_phb4.c
@@ -1773,6 +1773,7 @@ static void pnv_phb4_root_bus_class_init(ObjectClass
*klass, void *data)
static const TypeInfo pnv_phb4_root_bus_info = {
.name = TYPE_PNV_PHB4_ROOT_BUS,
.parent = TYPE_PCIE_BUS,
+ .instance_size = sizeof(PnvPHB4RootBus),
.class_init = pnv_phb4_root_bus_class_init,
};
--
2.34.1
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, (continued)
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Bin Meng, 2022/09/21
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Daniel P . Berrangé, 2022/09/22
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Bin Meng, 2022/09/22
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Daniel P . Berrangé, 2022/09/27
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Bin Meng, 2022/09/28
- Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Daniel P . Berrangé, 2022/09/28
Re: [PATCH v2 35/39] tests/qtest: migration-test: Skip running some TLS cases for win32, Marc-André Lureau, 2022/09/22
[PATCH v2 38/39] tests/qtest: Enable qtest build on Windows, Bin Meng, 2022/09/20
[PATCH v2 28/39] hw/pci-host: pnv_phb{3, 4}: Fix heap out-of-bound access failure,
Bin Meng <=
[PATCH v2 17/39] tests/qtest: libqtest: Exclude the *_fds APIs for win32, Bin Meng, 2022/09/20
[PATCH v2 39/39] docs/devel: testing: Document writing portable test cases, Bin Meng, 2022/09/20