[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/27] qapi audio: Elide redundant has_FOO in generated C
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 07/27] qapi audio: Elide redundant has_FOO in generated C |
Date: |
Fri, 16 Sep 2022 10:13:50 +0100 |
User-agent: |
Mutt/2.2.6 (2022-06-05) |
On Thu, Sep 15, 2022 at 10:42:57PM +0200, Markus Armbruster wrote:
> The has_FOO for pointer-valued FOO are redundant, except for arrays.
> They are also a nuisance to work with. Recent commit "qapi: Start to
> elide redundant has_FOO in generated C" provided the means to elide
> them step by step. This is the step for qapi/audio.json.
>
> Said commit explains the transformation in more detail. The invariant
> violations mentioned there do not occur here.
>
> Additionally, helper get_str() loses its @has_dst parameter.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> audio/alsaaudio.c | 2 +-
> audio/audio.c | 6 ++----
> audio/audio_legacy.c | 17 +++++++----------
> audio/ossaudio.c | 8 +++-----
> audio/paaudio.c | 12 ++++++------
> audio/wavaudio.c | 2 +-
> scripts/qapi/schema.py | 1 -
> 7 files changed, 20 insertions(+), 28 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 05/27] qapi tests: Elide redundant has_FOO in generated C, (continued)
- [PATCH 05/27] qapi tests: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 17/27] qapi pci: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 04/27] qapi: Start to elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 19/27] qapi replay: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 08/27] qapi block: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 15/27] qapi misc: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 07/27] qapi audio: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- Re: [PATCH 07/27] qapi audio: Elide redundant has_FOO in generated C,
Daniel P . Berrangé <=
- [PATCH 14/27] qapi migration: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 03/27] docs/devel/qapi-code-gen: Extend example for next commit's change, Markus Armbruster, 2022/09/15
- [PATCH 21/27] qapi run-state: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 24/27] qapi transaction: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15
- [PATCH 12/27] qapi job: Elide redundant has_FOO in generated C, Markus Armbruster, 2022/09/15