|
From: | Marc-André Lureau |
Subject: | Re: [PATCH] tests: test-qga: close socket on failure to connect |
Date: | Mon, 5 Sep 2022 16:36:14 +0400 |
There is no portable way to handle EINTR on close() as far as I know. You can't really do anything but cross your fingers.
PaoloIl lun 5 set 2022, 13:36 Marc-André Lureau <marcandre.lureau@gmail.com> ha scritto:HiOn Mon, Sep 5, 2022 at 3:27 PM Paolo Bonzini <pbonzini@redhat.com> wrote:Reported by Coverity as CID 1432543.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/unit/test-qga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c
index a05a4628ed..d27ff94d13 100644
--- a/tests/unit/test-qga.c
+++ b/tests/unit/test-qga.c
@@ -32,6 +32,7 @@ static int connect_qga(char *path)
g_usleep(G_USEC_PER_SEC);
}
if (i++ == 10) {
+ close(s);We may want to be a bit safer and use g_close(), which handles EINTR too. AnywayReviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>return -1;
}
} while (ret == -1);
--
2.37.2
--Marc-André Lureau
[Prev in Thread] | Current Thread | [Next in Thread] |