Re: [PATCH v2 14/20] disas/nanomips: Remove function overloading

[Richard Henderson]

On 9/5/22 10:55, Milica Lazarevic wrote:
> -static uint64 copy(uint64 d)
> +static uint64 copy_ui(uint64 d)
>   {
>       return d;
>   }
>   
>   
> -static int64 copy(int64 d)
> +static int64 copy_i(int64 d)
>   {
>       return d;
>   }

These functions can surely just be removed.


> -static char *IMMEDIATE(uint64 value)
> +static char *IMMEDIATE_UI(uint64 value)
>  {
>      return img_format("0x%" PRIx64, value);
>  }
>  
>  
> -static char *IMMEDIATE(int64 value)
> +static char *IMMEDIATE_I(int64 value)
>  {
>      return img_format("%" PRId64, value);
>  }

And these would be removed by the previous conversion to direct use of printf values by 
the individual instructions.


r~