qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 06/20] disas/nanomips: Remove disasm methods from class


From: Richard Henderson
Subject: Re: [PATCH v2 06/20] disas/nanomips: Remove disasm methods from class
Date: Mon, 5 Sep 2022 12:08:01 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 9/5/22 10:55, Milica Lazarevic wrote:
NMD class methods with the disassembly_function type like
NMD::ABS_D, NMD::ABS_S, etc. are removed from the class. They're now
declared global static functions. Therefore, typedef of the function
pointer, disassembly_function is defined outside of the class.

Now that disassembly_function type functions are not part of the NMD
class we can't access them using the this pointer. Thus, the use of
the this pointer has been deleted.

Signed-off-by: Milica Lazarevic<milica.lazarevic@syrmia.com>
Reviewed-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
  disas/nanomips.cpp | 2546 ++++++++++++++++++++++----------------------
  disas/nanomips.h   |  642 +----------
  2 files changed, 1275 insertions(+), 1913 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]