[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/11] target/openrisc: Fix memory reading in debugger
From: |
Stafford Horne |
Subject: |
[PATCH v2 02/11] target/openrisc: Fix memory reading in debugger |
Date: |
Mon, 4 Jul 2022 06:28:14 +0900 |
In commit f0655423ca ("target/openrisc: Reorg tlb lookup") data and
instruction TLB reads were combined. This, broke debugger reads where
we first tried to map using the data tlb then fall back to the
instruction tlb.
This patch replicates this logic by first requesting a PAGE_READ
protection mapping then falling back to PAGE_EXEC.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
target/openrisc/mmu.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/target/openrisc/mmu.c b/target/openrisc/mmu.c
index d7e1320998..0b8afdbacf 100644
--- a/target/openrisc/mmu.c
+++ b/target/openrisc/mmu.c
@@ -148,7 +148,13 @@ hwaddr openrisc_cpu_get_phys_page_debug(CPUState *cs,
vaddr addr)
case SR_DME | SR_IME:
/* The mmu is definitely enabled. */
excp = get_phys_mmu(cpu, &phys_addr, &prot, addr,
- PAGE_EXEC | PAGE_READ | PAGE_WRITE,
+ PAGE_READ,
+ (sr & SR_SM) != 0);
+ if (!excp) {
+ return phys_addr;
+ }
+ excp = get_phys_mmu(cpu, &phys_addr, &prot, addr,
+ PAGE_EXEC,
(sr & SR_SM) != 0);
return excp ? -1 : phys_addr;
--
2.36.1
- [PATCH v2 00/11] OpenRISC Virtual Machine, Stafford Horne, 2022/07/03
- [PATCH v2 02/11] target/openrisc: Fix memory reading in debugger,
Stafford Horne <=
- [PATCH v2 01/11] hw/openrisc: Split re-usable boot time apis out to boot.c, Stafford Horne, 2022/07/03
- [PATCH v2 03/11] goldfish_rtc: Add endianness property, Stafford Horne, 2022/07/03
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Anup Patel, 2022/07/03
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Richard Henderson, 2022/07/04
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Laurent Vivier, 2022/07/04
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Richard Henderson, 2022/07/04
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Laurent Vivier, 2022/07/04
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Stafford Horne, 2022/07/04
- Re: [PATCH v2 03/11] goldfish_rtc: Add endianness property, Jason A. Donenfeld, 2022/07/04