[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 4/7] hw/isa/piix{3,4}: QOM'ify PCI device creation and wir
From: |
Bernhard Beschow |
Subject: |
Re: [PATCH v3 4/7] hw/isa/piix{3,4}: QOM'ify PCI device creation and wiring |
Date: |
Mon, 30 May 2022 21:00:04 +0000 |
Am 30. Mai 2022 13:17:12 UTC schrieb "Philippe Mathieu-Daudé" <f4bug@amsat.org>:
>Hi Bernhard,
Hi Philippe,
>On 28/5/22 21:20, Bernhard Beschow wrote:
>> PCI interrupt wiring and device creation (piix4 only) were performed
>> in create() functions which are obsolete. Move these tasks into QOM
>> functions to modernize the code.
>>
>> In order to avoid duplicate checking for xen_enabled() the piix3 realize
>> methods are now split.
>>
>> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
>> ---
>> hw/isa/piix3.c | 67 +++++++++++++++++++++++++++++++++-----------------
>> hw/isa/piix4.c | 30 ++++++++++++++++------
>> 2 files changed, 67 insertions(+), 30 deletions(-)
>
>While this is the same chipset family, these models are maintained by
>different people... Do you mind splitting?
Will do. I'd split the whole series then.
>For PIIX4 part:
>Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
- [PATCH v3 0/7] QOM'ify PIIX southbridge creation, Bernhard Beschow, 2022/05/28
- [PATCH v3 2/7] hw/isa/piix4: Use object_initialize_child() for embedded struct, Bernhard Beschow, 2022/05/28
- [PATCH v3 3/7] hw/isa/piix{3, 4}: Move pci_map_irq_fn's near pci_set_irq_fn's, Bernhard Beschow, 2022/05/28
- [PATCH v3 4/7] hw/isa/piix{3, 4}: QOM'ify PCI device creation and wiring, Bernhard Beschow, 2022/05/28
- [PATCH v3 7/7] hw/isa/piix{3, 4}: Inline and remove create() functions, Bernhard Beschow, 2022/05/28
- [PATCH v3 5/7] hw/isa/piix{3, 4}: Factor out ISABus retrieval from create() functions, Bernhard Beschow, 2022/05/28
- [PATCH v3 6/7] hw/isa/piix4: QOM'ify PIIX4 PM creation, Bernhard Beschow, 2022/05/28
Re: [PATCH v3 0/7] QOM'ify PIIX southbridge creation, Mark Cave-Ayland, 2022/05/29