|
From: | Richard Henderson |
Subject: | Re: [PULL 2/3] qga-win32: Add support for NVME but type |
Date: | Mon, 23 May 2022 13:55:02 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 5/23/22 12:41, Konstantin Kostiuk wrote:
Bus type spaces (Indicates a storage spaces bus) is not supported, so return it as unknown. Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> Message-Id: <20220520201401.706630-1-kkostiuk@redhat.com> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com> --- qga/commands-win32.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index dcdeb76a68..36f94c0f9c 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -490,6 +490,11 @@ static GuestDiskBusType win2qemu[] = { #if (_WIN32_WINNT >= 0x0601) [BusTypeVirtual] = GUEST_DISK_BUS_TYPE_VIRTUAL, [BusTypeFileBackedVirtual] = GUEST_DISK_BUS_TYPE_FILE_BACKED_VIRTUAL, + /* + * BusTypeSpaces currently is not suported + */ + [BusTypeSpaces] = GUEST_DISK_BUS_TYPE_UNKNOWN, + [BusTypeNvme] = GUEST_DISK_BUS_TYPE_NVME, #endif };
Build fails:../qga/commands-win32.c:496:6: error: 'BusTypeSpaces' undeclared here (not in a function); did you mean 'BusTypeSas'?
496 | [BusTypeSpaces] = GUEST_DISK_BUS_TYPE_UNKNOWN, | ^~~~~~~~~~~~~ | BusTypeSas ../qga/commands-win32.c:496:6: error: array index in initializer not of integer type ../qga/commands-win32.c:496:6: note: (near initialization for 'win2qemu')../qga/commands-win32.c:497:6: error: 'BusTypeNvme' undeclared here (not in a function); did you mean 'BusTypeMmc'?
497 | [BusTypeNvme] = GUEST_DISK_BUS_TYPE_NVME, | ^~~~~~~~~~~ | BusTypeMmc ../qga/commands-win32.c:497:6: error: array index in initializer not of integer type ../qga/commands-win32.c:497:6: note: (near initialization for 'win2qemu') r~
[Prev in Thread] | Current Thread | [Next in Thread] |