|
From: | Richard Henderson |
Subject: | Re: [PATCH v3 23/49] semihosting: Split out semihost_sys_open |
Date: | Mon, 23 May 2022 08:46:29 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 5/23/22 06:30, Peter Maydell wrote:
So this changes the errno values in the not-gdb case from being host errno values to the gdb protocol ones. Errnos in Arm semihosting are an unspecified mess, so maybe we can get away with changing the existing QEMU behaviour; but I'd rather we didn't do it one syscall at a time in a big refactoring series if we can avoid it.
Ok.Also, I think I mentioned this in the v2 cover but not here, that having done the errno conversion here for arm semihosting, it worked less well for mips and xtensa, which have a rather better defined set of errnos.
My question from v2 was: should we in fact convert back from gdb's errno to host errno in gdbstub.c handle_file_io(), and then let each semihosting backend convert from host to guest?
r~
[Prev in Thread] | Current Thread | [Next in Thread] |