[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 5/9] crypto: Implement RSA algorithm by hogweed
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v6 5/9] crypto: Implement RSA algorithm by hogweed |
Date: |
Mon, 23 May 2022 10:43:31 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
On Sat, May 14, 2022 at 08:55:00AM +0800, zhenwei pi wrote:
> From: Lei He <helei.sig11@bytedance.com>
>
> Implement RSA algorithm by hogweed from nettle. Thus QEMU supports
> a 'real' RSA backend to handle request from guest side. It's
> important to test RSA offload case without OS & hardware requirement.
>
> Signed-off-by: lei he <helei.sig11@bytedance.com>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> crypto/akcipher-nettle.c.inc | 451 +++++++++++++++++++++++++++++++++++
> crypto/akcipher.c | 4 +
> crypto/meson.build | 4 +
> crypto/rsakey-builtin.c.inc | 200 ++++++++++++++++
> crypto/rsakey-nettle.c.inc | 158 ++++++++++++
> crypto/rsakey.c | 44 ++++
> crypto/rsakey.h | 94 ++++++++
> meson.build | 11 +
> 8 files changed, 966 insertions(+)
> create mode 100644 crypto/akcipher-nettle.c.inc
> create mode 100644 crypto/rsakey-builtin.c.inc
> create mode 100644 crypto/rsakey-nettle.c.inc
> create mode 100644 crypto/rsakey.c
> create mode 100644 crypto/rsakey.h
> diff --git a/crypto/rsakey.h b/crypto/rsakey.h
> new file mode 100644
> index 0000000000..17bb22333d
> --- /dev/null
> +++ b/crypto/rsakey.h
> @@ -0,0 +1,94 @@
> +
> +#ifndef QCRYPTO_RSAKEY_H
> +#define QCRYPTO_RSAKEY_H
> +
> +#include <nettle/bignum.h>
This should be removed -it isn't needed and breaks build on
without-nettle build configurations.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v6 0/9] Introduce akcipher service for virtio-crypto, zhenwei pi, 2022/05/13
- [PATCH v6 3/9] crypto: Introduce akcipher crypto class, zhenwei pi, 2022/05/13
- [PATCH v6 1/9] virtio-crypto: header update, zhenwei pi, 2022/05/13
- [PATCH v6 2/9] qapi: crypto-akcipher: Introduce akcipher types to qapi, zhenwei pi, 2022/05/13
- [PATCH v6 4/9] crypto: add ASN.1 DER decoder, zhenwei pi, 2022/05/13
- [PATCH v6 5/9] crypto: Implement RSA algorithm by hogweed, zhenwei pi, 2022/05/13
- [PATCH v6 6/9] crypto: Implement RSA algorithm by gcrypt, zhenwei pi, 2022/05/13
- [PATCH v6 7/9] test/crypto: Add test suite for crypto akcipher, zhenwei pi, 2022/05/13
- [PATCH v6 8/9] tests/crypto: Add test suite for RSA keys, zhenwei pi, 2022/05/13
- [PATCH v6 9/9] crypto: Introduce RSA algorithm, zhenwei pi, 2022/05/13