[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v4 10/36] i386/kvm: Move architectural CPUID leaf generat
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [RFC PATCH v4 10/36] i386/kvm: Move architectural CPUID leaf generation to separate helper |
|
Date: |
Mon, 23 May 2022 11:06:29 +0200 |
On Thu, May 12, 2022 at 10:48:14AM -0700, Isaku Yamahata wrote:
> On Thu, May 12, 2022 at 11:17:37AM +0800,
> Xiaoyao Li <xiaoyao.li@intel.com> wrote:
>
> > diff --git a/target/i386/kvm/kvm_i386.h b/target/i386/kvm/kvm_i386.h
> > index b434feaa6b1d..5c7972f617e8 100644
> > --- a/target/i386/kvm/kvm_i386.h
> > +++ b/target/i386/kvm/kvm_i386.h
> > @@ -24,6 +24,10 @@
> > #define kvm_ioapic_in_kernel() \
> > (kvm_irqchip_in_kernel() && !kvm_irqchip_is_split())
> >
> > +#define KVM_MAX_CPUID_ENTRIES 100
>
> In Linux side, the value was bumped to 256. Opportunistically let's make it
> same.
When doing so use a separate patch please. A patch like this -- moving
around code without functional changes -- should not be mixed with other
changes.
take care,
Gerd