[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/49] semihosting: Clean up common_semi_open_cb
From: |
Richard Henderson |
Subject: |
[PATCH v3 11/49] semihosting: Clean up common_semi_open_cb |
Date: |
Fri, 20 May 2022 17:03:22 -0700 |
Use common_semi_cb to return results instead of calling
set_swi_errno and common_semi_set_ret directly.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
semihosting/arm-compat-semi.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index 8792180974..1f1c5b4c9e 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -364,15 +364,13 @@ static int common_semi_open_guestfd;
static void
common_semi_open_cb(CPUState *cs, target_ulong ret, target_ulong err)
{
- if (ret == (target_ulong)-1) {
- errno = err;
- set_swi_errno(cs, -1);
+ if (err) {
dealloc_guestfd(common_semi_open_guestfd);
} else {
associate_guestfd(common_semi_open_guestfd, ret);
ret = common_semi_open_guestfd;
}
- common_semi_set_ret(cs, ret);
+ common_semi_cb(cs, ret, err);
}
static target_ulong
--
2.34.1
- [PATCH v3 02/49] semihosting: Return failure from softmmu-uaccess.h functions, (continued)
- [PATCH v3 02/49] semihosting: Return failure from softmmu-uaccess.h functions, Richard Henderson, 2022/05/20
- [PATCH v3 10/49] semihosting: Clean up common_semi_flen_cb, Richard Henderson, 2022/05/20
- [PATCH v3 06/49] semihosting: Simplify softmmu_lock_user_string, Richard Henderson, 2022/05/20
- [PATCH v3 08/49] semihosting: Inline set_swi_errno into common_semi_cb, Richard Henderson, 2022/05/20
- [PATCH v3 09/49] semihosting: Adjust error checking in common_semi_cb, Richard Henderson, 2022/05/20
- [PATCH v3 05/49] semihosting: Add target_strlen for softmmu-uaccess.h, Richard Henderson, 2022/05/20
- [PATCH v3 11/49] semihosting: Clean up common_semi_open_cb,
Richard Henderson <=
- [PATCH v3 07/49] semihosting: Split out guestfd.c, Richard Henderson, 2022/05/20
- [PATCH v3 04/49] semihosting: Move softmmu-uaccess.h functions out of line, Richard Henderson, 2022/05/20
- [PATCH v3 13/49] semihosting: Move common-semi.h to include/semihosting/, Richard Henderson, 2022/05/20
- [PATCH v3 24/49] semihosting: Split out semihost_sys_close, Richard Henderson, 2022/05/20
- [PATCH v3 16/49] include/exec: Define errno values in gdbstub.h, Richard Henderson, 2022/05/20
- [PATCH v3 12/49] semihosting: Return void from do_common_semihosting, Richard Henderson, 2022/05/20
- [PATCH v3 18/49] semihosting: Split is_64bit_semihosting per target, Richard Henderson, 2022/05/20