[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/35] acpi: make isa_build_aml() support AcpiDevAmlIf interf
From: |
Ani Sinha |
Subject: |
Re: [PATCH 02/35] acpi: make isa_build_aml() support AcpiDevAmlIf interface |
Date: |
Wed, 18 May 2022 15:43:45 +0530 |
On Mon, May 16, 2022 at 8:56 PM Igor Mammedov <imammedo@redhat.com> wrote:
>
> To allow incremental conversion from ISADeviceClass::build_aml
> to AcpiDevAmlIf, add support for the later without removing
> the former. Once conversion is complete, another commit will
> drop ISADeviceClass::build_aml related code.
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Ani Sinha <ani@anisinha.ca>
> ---
> hw/isa/isa-bus.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c
> index cd5ad3687d..237e2cee12 100644
> --- a/hw/isa/isa-bus.c
> +++ b/hw/isa/isa-bus.c
> @@ -24,6 +24,7 @@
> #include "hw/sysbus.h"
> #include "sysemu/sysemu.h"
> #include "hw/isa/isa.h"
> +#include "hw/acpi/acpi_aml_interface.h"
>
> static ISABus *isabus;
>
> @@ -196,8 +197,12 @@ void isa_build_aml(ISABus *bus, Aml *scope)
> QTAILQ_FOREACH(kid, &bus->parent_obj.children, sibling) {
> dev = ISA_DEVICE(kid->child);
> dc = ISA_DEVICE_GET_CLASS(dev);
> + bool has_build_dev_aml = !!object_dynamic_cast(OBJECT(dev),
> + TYPE_ACPI_DEV_AML_IF);
> if (dc->build_aml) {
> dc->build_aml(dev, scope);
> + } else if (has_build_dev_aml) {
> + call_dev_aml_func(DEVICE(dev), scope);
> }
> }
> }
> --
> 2.31.1
>
- [PATCH 00/35] pc/q35: refactor ISA and SMBUS AML generation, Igor Mammedov, 2022/05/16
- [PATCH 01/35] acpi: add interface to build device specific AML, Igor Mammedov, 2022/05/16
- [PATCH 03/35] acpi: fdc-isa: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/05/16
- [PATCH 02/35] acpi: make isa_build_aml() support AcpiDevAmlIf interface, Igor Mammedov, 2022/05/16
- Re: [PATCH 02/35] acpi: make isa_build_aml() support AcpiDevAmlIf interface,
Ani Sinha <=
- [PATCH 04/35] acpi: parallel port: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/05/16
- [PATCH 06/35] acpi: mc146818rtc: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/05/16
- [PATCH 05/35] acpi: serial-is: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/05/16
- [PATCH 07/35] acpi: pckbd: replace ISADeviceClass::build_aml with AcpiDevAmlIfClass:build_dev_aml, Igor Mammedov, 2022/05/16
- [PATCH 08/35] isa-bus: drop no longer used ISADeviceClass::build_aml, Igor Mammedov, 2022/05/16
- [PATCH 10/35] tests: acpi: q35: add test for smbus-ipmi device, Igor Mammedov, 2022/05/16
- [PATCH 12/35] tests: acpi: whitelist DSDT.ipmismbus expected blob, Igor Mammedov, 2022/05/16
- [PATCH 13/35] ipmi: acpi: use relative path to resource source, Igor Mammedov, 2022/05/16
- [PATCH 11/35] tests: acpi: update expected blob DSDT.ipmismbus, Igor Mammedov, 2022/05/16
- [PATCH 14/35] tests: acpi: update expected DSDT.ipmismbus blob, Igor Mammedov, 2022/05/16