|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/3] capstone: Allow version 3.0.5 again |
Date: | Mon, 16 May 2022 09:46:57 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 5/16/22 08:46, Peter Maydell wrote:
On Mon, 16 May 2022 at 16:43, Thomas Huth <thuth@redhat.com> wrote:According to https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.henderson@linaro.org/ there was an issue with Capstone 3 from Ubuntu 18. Now that we removed support for Ubuntu 18.04, that issue should hopefully not bite us anymore. Compiling with version 3.0.5 seems to work fine on other systems, so let's allow that version again.Commit bcf368626cb33c4d says the reason for requiring capstone=4.0 was "We're about to use a portion of the 4.0 API", not"Ubuntu's specific capstone 3 is broken"...
Looks like the patch to which this referred was never merged -- CS_ARCH_RISCV.I still have a branch with riscv support sitting in it, from Sep 2020. Sadly, I never posted that patch, nor said why I withheld it in the end. Perhaps the actual riscv support in capstone was poor at the time.
The 4.0 requirement patch itself was kept for Ubuntu 18's issue: https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07542.html # Changes for v4: # * Require v4.0 from the system library. # Fixes an issue AJB found from v3.0.5 from ubuntu 18. r~
[Prev in Thread] | Current Thread | [Next in Thread] |