qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 3/8] qmp: add filtering of statistics by target vCPU


From: Paolo Bonzini
Subject: Re: [PATCH v3 3/8] qmp: add filtering of statistics by target vCPU
Date: Mon, 16 May 2022 16:31:25 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 5/16/22 14:04, Markus Armbruster wrote:
+bool str_in_list(const char *string, strList *list)
+{
+    strList *str_list = NULL;
+
+    if (!list) {
+        return true;

Are you sure the empty list is supposed to contain any string?

Well, it matches vcpus missing below but it breaks with vcpus = [] (nonsensical but valid).

So I'll have to catch vcpus = [] and names = [] up in qmp_query_stats.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]