[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 1/8] meson.build: Fix docker-test-build@alpine when inclu
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v13 1/8] meson.build: Fix docker-test-build@alpine when including linux/errqueue.h |
Date: |
Mon, 16 May 2022 13:51:43 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
* Daniel P. Berrangé (berrange@redhat.com) wrote:
> On Mon, May 16, 2022 at 12:30:15PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrangé (berrange@redhat.com) wrote:
> > > On Mon, May 16, 2022 at 12:13:16PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Leonardo Bras (leobras@redhat.com) wrote:
> > > > > A build error happens in alpine CI when linux/errqueue.h is included
> > > > > in io/channel-socket.c, due to redefining of 'struct
> > > > > __kernel_timespec':
> > > >
> > > > OK, looks to be same mechanism as other meson tests.
> > >
> > > >
> > > > Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> > >
> > > As of about an hour or so ago, this patch should not be required.
> > >
> > > https://gitlab.alpinelinux.org/alpine/aports/-/issues/13813
> >
> > I'll take it anyway as protection against any other broken build envs.
>
> Can you update the commit message at least then.
Sure, I've added:
[dgilbert: This has been fixed in Alpine issue 13813 and liburing]
> The root casue trigger for the bug is the OS uses a busybox
I guess you mean musl??
> impl of mkdtemp, which isn't compat with the args liburing
> configure was previously using. I doubt there are many such OS
> around to be honest, as most will use coreutils.
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
[PATCH v13 2/8] QIOChannel: Add flags on io_writev and introduce io_flush callback, Leonardo Bras, 2022/05/13
[PATCH v13 3/8] QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX, Leonardo Bras, 2022/05/13
[PATCH v13 4/8] migration: Add zero-copy-send parameter for QMP/HMP for Linux, Leonardo Bras, 2022/05/13
[PATCH v13 5/8] migration: Add migrate_use_tls() helper, Leonardo Bras, 2022/05/13
[PATCH v13 6/8] multifd: multifd_send_sync_main now returns negative on error, Leonardo Bras, 2022/05/13
[PATCH v13 7/8] multifd: Send header packet without flags if zero-copy-send is enabled, Leonardo Bras, 2022/05/13
[PATCH v13 8/8] multifd: Implement zero copy write in multifd migration (multifd-zero-copy), Leonardo Bras, 2022/05/13