[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/8] qmp: Support for querying stats
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 1/8] qmp: Support for querying stats |
Date: |
Fri, 13 May 2022 16:39:07 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 5/13/22 14:52, Markus Armbruster wrote:
>>> +# @StatsResult:
>>> +#
>>> +# @provider: provider for this set of statistics.
>>> +# @qom-path: QOM path of the object for which the statistics are returned
>> Since @qom-path is optional, we better document when it's present. In
>> the review thread for v1, you explained "Only if the target is vcpus,
>> for the current set of targets." More general, and hopefully still
>> correct, would be "Present if that object is a QOM object", but the
>> phrasing feels rather clumsy. Would appending ", if any" suffice?
>>
>
> Alternatively:
>
> # @qom-path: Path to the object for which the statistics are returned,
> # if the object is exposed in the QOM tree
Sold!
- [PATCH v2 0/8] qmp, hmp: statistics subsystem and KVM suport., Paolo Bonzini, 2022/05/11
- [PATCH v2 2/8] kvm: Support for querying fd-based stats, Paolo Bonzini, 2022/05/11
- [PATCH v2 3/8] qmp: add filtering of statistics by target vCPU, Paolo Bonzini, 2022/05/11
- [PATCH v2 4/8] hmp: add basic "info stats" implementation, Paolo Bonzini, 2022/05/11
- [PATCH v2 5/8] qmp: add filtering of statistics by provider, Paolo Bonzini, 2022/05/11
- [PATCH v2 6/8] hmp: add filtering of statistics by provider, Paolo Bonzini, 2022/05/11
- [PATCH v2 8/8] hmp: add filtering of statistics by name, Paolo Bonzini, 2022/05/11
- [PATCH v2 7/8] qmp: add filtering of statistics by name, Paolo Bonzini, 2022/05/11