[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/9] vfio/migration: Reset device if setting recover state fails
From: |
Avihai Horon |
Subject: |
[PATCH 7/9] vfio/migration: Reset device if setting recover state fails |
Date: |
Thu, 12 May 2022 18:43:18 +0300 |
If vfio_migration_set_state() fails to set the device in the requested
state it tries to put it in a recover state. If setting the device in
the recover state fails as well, hw_error is triggered and the VM is
aborted.
To improve user experience and avoid VM data loss, reset the device with
VFIO_RESET_DEVICE instead of aborting the VM.
Signed-off-by: Avihai Horon <avihaih@nvidia.com>
---
hw/vfio/migration.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 8943ccbace..aec8afcd6c 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -89,8 +89,16 @@ static int vfio_migration_set_state(VFIODevice *vbasedev,
/* Try to put the device in some good state */
mig_state->device_state = recover_state;
if (ioctl(vbasedev->fd, VFIO_DEVICE_FEATURE, feature)) {
- hw_error("%s: Device in error state, can't recover",
- vbasedev->name);
+ if (ioctl(vbasedev->fd, VFIO_DEVICE_RESET)) {
+ hw_error("%s: Device in error state, can't recover",
+ vbasedev->name);
+ }
+
+ error_report(
+ "%s: Device was reset due to failure in changing device state
to recover state %s",
+ vbasedev->name, mig_state_to_str(recover_state));
+
+ return -1;
}
error_report("%s: Failed changing device state to %s", vbasedev->name,
--
2.21.3
- [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), (continued)
- [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Avihai Horon, 2022/05/12
- Re: [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Juan Quintela, 2022/05/16
- Re: [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Avihai Horon, 2022/05/17
- Re: [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Juan Quintela, 2022/05/18
- Re: [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Jason Gunthorpe, 2022/05/18
- Re: [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Daniel P . Berrangé, 2022/05/18
- Re: [PATCH 5/9] migration/qemu-file: Add qemu_file_get_to_fd(), Jason Gunthorpe, 2022/05/18
[PATCH 6/9] vfio/migration: Implement VFIO migration protocol v2, Avihai Horon, 2022/05/12
[PATCH 7/9] vfio/migration: Reset device if setting recover state fails,
Avihai Horon <=
[PATCH 8/9] vfio: Alphabetize migration section of VFIO trace-events file, Avihai Horon, 2022/05/12
[PATCH 9/9] docs/devel: Align vfio-migration docs to VFIO migration v2, Avihai Horon, 2022/05/12
Re: [PATCH 0/9] vfio/migration: Implement VFIO migration protocol v2, Alex Williamson, 2022/05/12