[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] Clean up header guards that don't match their file name
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 1/4] Clean up header guards that don't match their file name |
Date: |
Mon, 09 May 2022 07:16:43 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Markus Armbruster <armbru@redhat.com> writes:
> Header guard symbols should match their file name to make guard
> collisions less likely.
>
> Cleaned up with scripts/clean-header-guards.pl, followed by some
> renaming of new guard symbols picked by the script to better ones.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
[...]
> diff --git a/ebpf/rss.bpf.skeleton.h b/ebpf/rss.bpf.skeleton.h
> index 126683eb87..4bca5d223a 100644
> --- a/ebpf/rss.bpf.skeleton.h
> +++ b/ebpf/rss.bpf.skeleton.h
> @@ -1,8 +1,9 @@
> /* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
>
> /* THIS FILE IS AUTOGENERATED! */
> -#ifndef __RSS_BPF_SKEL_H__
> -#define __RSS_BPF_SKEL_H__
> +
> +#ifndef EBPF_RSS_BPF_SKELETON_H
> +#define EBPF_RSS_BPF_SKELETON_H
>
> #include <stdlib.h>
> #include <bpf/libbpf.h>
> @@ -428,4 +429,4 @@ err:
> return -1;
> }
>
> -#endif /* __RSS_BPF_SKEL_H__ */
> +#endif /* EBPF_RSS_BPF_SKELETON_H */
Dropping this one because it's actually generated from
tools/ebpf/rss.bpf.c. See
https://lists.nongnu.org/archive/html/qemu-devel/2022-05/msg01392.html
Message-ID:
<CACGkMEvoug0H10H+4=7yjB7UyRK+1Ugyq3xgGpC1a2wWy4jX_Q@mail.gmail.com>
[...]
- [PATCH 0/4] Clean up header guards again, Markus Armbruster, 2022/05/06
- [PATCH 4/4] Clean up decorations and whitespace around header guards, Markus Armbruster, 2022/05/06
- [PATCH 3/4] Normalize header guard symbol definition, Markus Armbruster, 2022/05/06
- [PATCH 1/4] Clean up header guards that don't match their file name, Markus Armbruster, 2022/05/06
- Re: [PATCH 1/4] Clean up header guards that don't match their file name,
Markus Armbruster <=
- [PATCH 2/4] Clean up ill-advised or unusual header guards, Markus Armbruster, 2022/05/06
- Re: [PATCH 0/4] Clean up header guards again, Richard Henderson, 2022/05/07