[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Patch 1/3] hw/vfio/pci: fix vfio_pci_hot_reset_result trace point
From: |
Eric Auger |
Subject: |
Re: [Patch 1/3] hw/vfio/pci: fix vfio_pci_hot_reset_result trace point |
Date: |
Mon, 2 May 2022 16:43:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
Hi Alex,
On 5/2/22 16:35, Alex Williamson wrote:
> On Mon, 2 May 2022 02:42:21 -0700
> Yi Liu <yi.l.liu@intel.com> wrote:
>
>> From: Eric Auger <eric.auger@redhat.com>
>>
>> Properly output the errno string.
> More explanation please, why is it broken and how does this fix it?
> Thanks,
"%m" format specifier is not interpreted by the trace infrastructure and
thus "%m" is output instead of the actual errno string. Fix it by
outputting
strerror(errno).
Thanks
Eric
>
> Alex
>
>> Signed-off-by: Eric Auger <eric.auger@redhat.com>
>> Signed-off-by: Yi Liu <yi.l.liu@intel.com>
>> ---
>> hw/vfio/pci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
>> index 9fd9faee1d..4a66376be6 100644
>> --- a/hw/vfio/pci.c
>> +++ b/hw/vfio/pci.c
>> @@ -2337,7 +2337,7 @@ static int vfio_pci_hot_reset(VFIOPCIDevice *vdev,
>> bool single)
>> g_free(reset);
>>
>> trace_vfio_pci_hot_reset_result(vdev->vbasedev.name,
>> - ret ? "%m" : "Success");
>> + ret ? strerror(errno) : "Success");
>>
>> out:
>> /* Re-enable INTx on affected devices */