[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 57/64] target/nios2: Advance pc when raising exceptions
From: |
Peter Maydell |
Subject: |
Re: [PATCH v7 57/64] target/nios2: Advance pc when raising exceptions |
Date: |
Fri, 22 Apr 2022 14:00:22 +0100 |
On Thu, 21 Apr 2022 at 17:51, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> The exception return address for nios2 is the instruction
> after the one that was executing at the time of the exception.
>
> We have so far implemented this by advancing the pc during the
> process of raising the exception. It is perhaps a little less
> confusing to do this advance in the translator (and helpers)
> when raising the exception in the first place, so that we may
> more closely match kernel sources.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v7 56/64] target/nios2: Implement EIC interrupt processing, (continued)
- [PATCH v7 55/64] target/nios2: Update helper_eret for shadow registers, Richard Henderson, 2022/04/21
- [PATCH v7 59/64] hw/intc: Vectored Interrupt Controller (VIC), Richard Henderson, 2022/04/21
- [PATCH v7 64/64] tests/tcg/nios2: Add test-shadow-1, Richard Henderson, 2022/04/21
- [PATCH v7 53/64] target/nios2: Introduce shadow register sets, Richard Henderson, 2022/04/21
- [PATCH v7 60/64] hw/nios2: Introduce Nios2MachineState, Richard Henderson, 2022/04/21
- [PATCH v7 54/64] target/nios2: Implement rdprs, wrprs, Richard Henderson, 2022/04/21
- [PATCH v7 57/64] target/nios2: Advance pc when raising exceptions, Richard Henderson, 2022/04/21
- Re: [PATCH v7 57/64] target/nios2: Advance pc when raising exceptions,
Peter Maydell <=
- [PATCH v7 62/64] hw/nios2: Machine with a Vectored Interrupt Controller, Richard Henderson, 2022/04/21
- [PATCH v7 63/64] tests/tcg/nios2: Add semihosting multiarch tests, Richard Henderson, 2022/04/21