[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 28/41] Use QEMU_SANITIZE_ADDRESS
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH 28/41] Use QEMU_SANITIZE_ADDRESS |
Date: |
Wed, 20 Apr 2022 18:35:11 +0400 |
On Wed, Apr 20, 2022 at 6:20 PM Thomas Huth <thuth@redhat.com> wrote:
>
> On 20/04/2022 15.26, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > tests/qtest/fdc-test.c | 2 +-
> > util/coroutine-ucontext.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/qtest/fdc-test.c b/tests/qtest/fdc-test.c
> > index 4aa72f36431f..0b3c2c0d523f 100644
> > --- a/tests/qtest/fdc-test.c
> > +++ b/tests/qtest/fdc-test.c
> > @@ -550,7 +550,7 @@ static void fuzz_registers(void)
> >
> > static bool qtest_check_clang_sanitizer(void)
> > {
> > -#if defined(__SANITIZE_ADDRESS__) || __has_feature(address_sanitizer)
> > +#ifdef QEMU_SANITIZE_ADDRESS
> > return true;
> > #else
> > g_test_skip("QEMU not configured using --enable-sanitizers");
> > diff --git a/util/coroutine-ucontext.c b/util/coroutine-ucontext.c
> > index 904b375192ca..52725f5344fb 100644
> > --- a/util/coroutine-ucontext.c
> > +++ b/util/coroutine-ucontext.c
> > @@ -30,7 +30,7 @@
> > #include <valgrind/valgrind.h>
> > #endif
> >
> > -#if defined(__SANITIZE_ADDRESS__) || __has_feature(address_sanitizer)
> > +#ifdef QEMU_SANITIZE_THREAD
>
> Shouldn't that be QEMU_SANITIZE_ADDRESS instead?
>
oops, thanks
- [PATCH 21/41] include: move qemu_fdatasync() to osdep, (continued)
- [PATCH 21/41] include: move qemu_fdatasync() to osdep, marcandre . lureau, 2022/04/20
- [PATCH 25/41] tests: remove block/qdict checks from check-qobject.c, marcandre . lureau, 2022/04/20
- [PATCH 24/41] include: move qdict_{crumple,flatten} declarations, marcandre . lureau, 2022/04/20
- [PATCH 26/41] compiler.h: add QEMU_SANITIZE_{ADDRESS,THREAD}, marcandre . lureau, 2022/04/20
- [PATCH 27/41] Use QEMU_SANITIZE_THREAD, marcandre . lureau, 2022/04/20
- [PATCH 28/41] Use QEMU_SANITIZE_ADDRESS, marcandre . lureau, 2022/04/20
- [PATCH 29/41] tests: run-time skip test-qga if TSAN is enabled, marcandre . lureau, 2022/04/20
- [PATCH 30/41] Move error_printf_unless_qmp() with monitor unit, marcandre . lureau, 2022/04/20
- [PATCH 31/41] qga: move qga_get_host_name(), marcandre . lureau, 2022/04/20
- [PATCH 32/41] qtest: simplify socket_send(), marcandre . lureau, 2022/04/20