Re: [PATCH v2 4/4] net: Use bundle mechanism

[Philippe Mathieu-Daudé]

On 26/2/22 13:45, Akihiko Odaki wrote:
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
>   configure         | 1 +
>   include/net/net.h | 2 +-
>   meson.build       | 1 +
>   net/tap.c         | 6 +++++-
>   qemu-options.hx   | 4 ++--
>   5 files changed, 10 insertions(+), 4 deletions(-)

> diff --git a/net/tap.c b/net/tap.c
> index c5cbeaa7a2b..3225d91ae00 100644
> --- a/net/tap.c
> +++ b/net/tap.c
> @@ -508,7 +508,11 @@ static int net_bridge_run_helper(const char *helper, const 
> char *bridge,
>       sigprocmask(SIG_BLOCK, &mask, &oldmask);
>   
>       if (!helper) {
> -        helper = default_helper = get_relocated_path(DEFAULT_BRIDGE_HELPER);
> +        helper = default_helper = find_bundle(DEFAULT_BUNDLE_BRIDGE_HELPER);
> +        if (!helper) {
> +            error_setg(errp, "birdge helper not found");

Typo "bridge".

> +            return -1;
> +        }
>       }