qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v2 00/25] Virtio Sound card Implementation


From: Gerd Hoffmann
Subject: Re: [RFC PATCH v2 00/25] Virtio Sound card Implementation
Date: Mon, 14 Feb 2022 11:44:03 +0100

  Hi,

> IMHO, all your patches can be merged in only one.

For the most part yes.  I'd keep the pci wrapper (aka -device
virtio-snd-pci) separate though.  Possibly also patches adding
significant functionality in the future (i.e. one patch with all
basics and playback support, one patch adding recording
functionality, ...).

> Morever it would help for
> review as some patches remove code done in previous patches.

Yes, squashing the incremental fixes at the end of the series makes
sense.

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]