[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 10/12] Hexagon (target/hexagon) fix bug in conv_df2uw_chop
From: |
Taylor Simpson |
Subject: |
[PATCH v2 10/12] Hexagon (target/hexagon) fix bug in conv_df2uw_chop |
Date: |
Wed, 9 Feb 2022 18:15:54 -0800 |
Fix typo that checked for 32 bit nan instead of 64 bit
Test case added in tests/tcg/hexagon/usr.c
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
target/hexagon/op_helper.c | 2 +-
tests/tcg/hexagon/usr.c | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c
index 7f40e09486..47729a48bd 100644
--- a/target/hexagon/op_helper.c
+++ b/target/hexagon/op_helper.c
@@ -829,7 +829,7 @@ uint32_t HELPER(conv_df2uw_chop)(CPUHexagonState *env,
float64 RssV)
uint32_t RdV;
arch_fpop_start(env);
/* Hexagon checks the sign before rounding */
- if (float64_is_neg(RssV) && !float32_is_any_nan(RssV)) {
+ if (float64_is_neg(RssV) && !float64_is_any_nan(RssV)) {
float_raise(float_flag_invalid, &env->fp_status);
RdV = 0;
} else {
diff --git a/tests/tcg/hexagon/usr.c b/tests/tcg/hexagon/usr.c
index a0006da25a..1b7d43baf4 100644
--- a/tests/tcg/hexagon/usr.c
+++ b/tests/tcg/hexagon/usr.c
@@ -1072,6 +1072,10 @@ int main()
TEST_P_OP_P(conv_df2d, DF_SNaN, 0xffffffffffffffffULL,
USR_FPINVF);
TEST_R_OP_P(conv_df2uw_chop, DF_QNaN, 0xffffffff,
USR_FPINVF);
TEST_R_OP_P(conv_df2uw_chop, DF_SNaN, 0xffffffff,
USR_FPINVF);
+
+ /* Test for typo in HELPER(conv_df2uw_chop) */
+ TEST_R_OP_P(conv_df2uw_chop, 0xffffff7f00000001ULL, 0xffffffff,
USR_FPINVF);
+
TEST_R_OP_P(conv_df2w_chop, DF_QNaN, 0xffffffff,
USR_FPINVF);
TEST_R_OP_P(conv_df2w_chop, DF_SNaN, 0xffffffff,
USR_FPINVF);
TEST_P_OP_P(conv_df2ud_chop, DF_QNaN, 0xffffffffffffffffULL,
USR_FPINVF);
--
2.17.1
- [PATCH v2 00/12] Hexagon bug fixes and additional tests, Taylor Simpson, 2022/02/09
- [PATCH v2 02/12] Hexagon HVX (target/hexagon) fix bug in HVX saturate instructions, Taylor Simpson, 2022/02/09
- [PATCH v2 10/12] Hexagon (target/hexagon) fix bug in conv_df2uw_chop,
Taylor Simpson <=
- [PATCH v2 03/12] Hexagon (target/hexagon) properly set FPINVF bit in sfcmp.uo and dfcmp.uo, Taylor Simpson, 2022/02/09
- [PATCH v2 08/12] Hexagon (tests/tcg/hexagon) update overflow test, Taylor Simpson, 2022/02/09
- [PATCH v2 12/12] Hexagon (target/hexagon) assignment to c4 should wait until packet commit, Taylor Simpson, 2022/02/09
- [PATCH v2 04/12] Hexagon (target/hexagon) properly handle SNaN in dfmin/dfmax/sfmin/sfmax, Taylor Simpson, 2022/02/09
- [PATCH v2 11/12] Hexagon (target/hexagon) make VyV operands use a unique temp, Taylor Simpson, 2022/02/09