[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 0/2] VFIO fixes 2022-02-03
|
From: |
Eric Auger |
|
Subject: |
Re: [PULL 0/2] VFIO fixes 2022-02-03 |
|
Date: |
Mon, 7 Feb 2022 10:10:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 |
Hi
On 2/5/22 12:19 PM, Philippe Mathieu-Daudé wrote:
> On 5/2/22 11:49, Peter Maydell wrote:
>> On Thu, 3 Feb 2022 at 22:38, Alex Williamson
>> <alex.williamson@redhat.com> wrote:
>>>
>>> The following changes since commit
>>> 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
>>>
>>> Merge remote-tracking branch
>>> 'remotes/hdeller/tags/hppa-updates-pull-request' into staging
>>> (2022-02-02 19:54:30 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
>>>
>>> for you to fetch changes up to
>>> 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
>>>
>>> hw/vfio/common: Silence ram device offset alignment error traces
>>> (2022-02-03 15:05:05 -0700)
>>>
>>> ----------------------------------------------------------------
>>> VFIO fixes 2022-02-03
>>>
>>> * Fix alignment warnings when using TPM CRB with vfio-pci devices
>>> (Eric Auger & Philippe Mathieu-Daudé)
>>
>> Hi; this has a format-string issue that means it doesn't build
>> on 32-bit systems:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>>
>> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
>> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
>> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
>> 'int'} [-Werror=format=]
>> error_report("%s received unaligned region %s iova=0x%"PRIx64
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../hw/vfio/common.c:899:26:
>> qemu_real_host_page_mask);
>> ~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> For intptr_t you want PRIxPTR.
>
> Thanks Peter.
>
> Eric, can you follow up on this series, looking at Igor comments wrt
> migration state?
Sure I will.
Eric
>
> Phil.
>