Re: [PATCH v4 10/11] 9p: darwin: meson: Allow VirtFS on Darwin

[Will Cohen]

Only because porting the proxy-helper to macOS is outside the scope of this particular patch. While some initial concepts around it have been considered by some of the contributors to this patch, those implementations weren't tested enough and the security implications weren't considered in full. We assume that this could be an additional implementation later on, if the functionality is considered important down the road.

On Sun, Feb 6, 2022 at 4:22 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:

On 6/2/22 21:07, Will Cohen wrote:
> From: Keno Fischer <keno@juliacomputing.com>
>
> Signed-off-by: Keno Fischer <keno@juliacomputing.com>
> [Michael Roitzsch: - Rebase for NixOS]
> Signed-off-by: Michael Roitzsch <reactorcontrol@icloud.com>
> [Will Cohen: - Rebase to master]
> Signed-off-by: Will Cohen <wwcohen@gmail.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> [Will Cohen: - Add check for pthread_fchdir_np to virtfs]
> Signed-off-by: Will Cohen <wwcohen@gmail.com>
> ---
>   fsdev/meson.build |  1 +
>   meson.build       | 14 ++++++++++----
>   2 files changed, 11 insertions(+), 4 deletions(-)

> -have_virtfs_proxy_helper = have_virtfs and have_tools
> +have_virtfs_proxy_helper = targetos == 'linux' and have_virtfs and have_tools

Why do you restrict the proxy-helper to Linux?