qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] audio: Add sndio backend


From: Brad Smith
Subject: Re: [PATCH v2] audio: Add sndio backend
Date: Sat, 15 Jan 2022 23:32:00 -0500
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:97.0) Gecko/20100101 Thunderbird/97.0

On 12/19/2021 4:07 PM, Volker Rümelin wrote:

Hi Alexandre,

sndio is the native API used by OpenBSD, although it has been ported to
other *BSD's and Linux (packages for Ubuntu, Debian, Void, Arch, etc.).

Signed-off-by: Brad Smith<brad@comstyle.com>
Signed-off-by: Alexandre Ratchov<alex@caoua.org>
---

Thank you for the reviews and all the comments. Here's a second diff
with all the suggested changes:

- Replace ISC license by SPDX-License-Identifier header
- Fix units (milli- vs micro-) in comment about SNDIO_LATENCY_US
- Drop outdated comment about the "size" argument of sndio_get_buffer_out()
- Fix AUDIO_FORMAT_U32 handling (missing "break" statement)
- Set {read,write] methods to audio_generic_{read,write} (fixes craches)
- Check if backend is enabled in sndio_poll_event()
- Usehttps://sndio.org  in description
- Mark options as available after 7.0 release (instead of 6.2)
- Describe sndio-specific options (dev, latency) in qemu-options.hx
- Add myself as reviewer to MAINTAINERS
- Style fixes: no space after function names, use 4-space indent
- Don't use "return foo()" if foo() returns void
- Include backend to audio_drivers_priority[]

Tested on OpenBSD, works as expected!

  MAINTAINERS            |   5 +
  audio/audio.c          |   1 +
  audio/audio_template.h |   2 +
  audio/meson.build      |   1 +
  audio/sndioaudio.c     | 555 +++++++++++++++++++++++++++++++++++++++++
  meson.build            |   9 +-
  meson_options.txt      |   4 +-

I just noticed you changed meson_options.txt but you forgot to regenerate scripts/meson-buildoptions.sh with make update-buildoptions in your build directory. See docs/devel/build-system.rst.

My bad. That was me. We were discussing the diff before Alexandre posted it. I was not sure
if the auto-generated file should be touched.


And I'm still convinced you should CC all maintainers of the files this patch changes.

With best regards,
Volker

  qapi/audio.json        |  25 +-
  qemu-options.hx        |  16 ++
  tests/vm/freebsd       |   3 +
  10 files changed, 618 insertions(+), 3 deletions(-)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]