[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 04/23] migration: Remove masking for compression
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v4 04/23] migration: Remove masking for compression |
Date: |
Tue, 11 Jan 2022 19:56:16 +0000 |
User-agent: |
Mutt/2.1.3 (2021-09-10) |
* Juan Quintela (quintela@redhat.com) wrote:
> Remove the mask in the call to ram_release_pages(). Nothing else does
> it, and if the offset has that bits set, we have a lot of trouble.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
Yeh same as in the other branch
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/ram.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 881fe4974e..fa49d22e69 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -1340,7 +1340,7 @@ static bool do_compress_ram_page(QEMUFile *f, z_stream
> *stream, RAMBlock *block,
> ram_addr_t offset, uint8_t *source_buf)
> {
> RAMState *rs = ram_state;
> - uint8_t *p = block->host + (offset & TARGET_PAGE_MASK);
> + uint8_t *p = block->host + offset;
> bool zero_page = false;
> int ret;
>
> @@ -1365,7 +1365,7 @@ static bool do_compress_ram_page(QEMUFile *f, z_stream
> *stream, RAMBlock *block,
> }
>
> exit:
> - ram_release_page(block->idstr, offset & TARGET_PAGE_MASK);
> + ram_release_page(block->idstr, offset);
> return zero_page;
> }
>
> --
> 2.34.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH v4 00/23] Migration: Transmit and detect zero pages in the multifd threads, Juan Quintela, 2022/01/11
- [PATCH v4 01/23] migration: All this fields are unsigned, Juan Quintela, 2022/01/11
- [PATCH v4 03/23] migration: ram_release_pages() always receive 1 page as argument, Juan Quintela, 2022/01/11
- [PATCH v4 04/23] migration: Remove masking for compression, Juan Quintela, 2022/01/11
- Re: [PATCH v4 04/23] migration: Remove masking for compression,
Dr. David Alan Gilbert <=
- [PATCH v4 02/23] migration: We only need last_stage in two places, Juan Quintela, 2022/01/11
- [PATCH v4 09/23] multifd: Make zlib use iov's, Juan Quintela, 2022/01/11
- [PATCH v4 05/23] migration: simplify do_compress_ram_page, Juan Quintela, 2022/01/11
- [PATCH v4 10/23] multifd: Make zstd use iov's, Juan Quintela, 2022/01/11
- [PATCH v4 07/23] multifd: Use proper maximum compression values, Juan Quintela, 2022/01/11
- [PATCH v4 08/23] multifd: Move iov from pages to params, Juan Quintela, 2022/01/11