[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 03/24] linux-user/alpha: Use force_sig_fault
From: |
Richard Henderson |
Subject: |
[PATCH v5 03/24] linux-user/alpha: Use force_sig_fault |
Date: |
Fri, 7 Jan 2022 13:32:22 -0800 |
Use the new function instead of setting up a target_siginfo_t
and calling queue_signal.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/alpha/cpu_loop.c | 61 ++++++++++++-------------------------
1 file changed, 19 insertions(+), 42 deletions(-)
diff --git a/linux-user/alpha/cpu_loop.c b/linux-user/alpha/cpu_loop.c
index caeea97b9d..de6e0c901c 100644
--- a/linux-user/alpha/cpu_loop.c
+++ b/linux-user/alpha/cpu_loop.c
@@ -27,8 +27,7 @@
void cpu_loop(CPUAlphaState *env)
{
CPUState *cs = env_cpu(env);
- int trapnr;
- target_siginfo_t info;
+ int trapnr, si_code;
abi_long sysret;
while (1) {
@@ -56,18 +55,10 @@ void cpu_loop(CPUAlphaState *env)
break;
case EXCP_OPCDEC:
do_sigill:
- info.si_signo = TARGET_SIGILL;
- info.si_errno = 0;
- info.si_code = TARGET_ILL_ILLOPC;
- info._sifields._sigfault._addr = env->pc;
- queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+ force_sig_fault(TARGET_SIGILL, TARGET_ILL_ILLOPC, env->pc);
break;
case EXCP_ARITH:
- info.si_signo = TARGET_SIGFPE;
- info.si_errno = 0;
- info.si_code = TARGET_FPE_FLTINV;
- info._sifields._sigfault._addr = env->pc;
- queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+ force_sig_fault(TARGET_SIGFPE, TARGET_FPE_FLTINV, env->pc);
break;
case EXCP_FEN:
/* No-op. Linux simply re-enables the FPU. */
@@ -76,20 +67,10 @@ void cpu_loop(CPUAlphaState *env)
switch (env->error_code) {
case 0x80:
/* BPT */
- info.si_signo = TARGET_SIGTRAP;
- info.si_errno = 0;
- info.si_code = TARGET_TRAP_BRKPT;
- info._sifields._sigfault._addr = env->pc;
- queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
- break;
+ goto do_sigtrap_brkpt;
case 0x81:
/* BUGCHK */
- info.si_signo = TARGET_SIGTRAP;
- info.si_errno = 0;
- info.si_code = TARGET_TRAP_UNK;
- info._sifields._sigfault._addr = env->pc;
- queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
- break;
+ goto do_sigtrap_unk;
case 0x83:
/* CALLSYS */
trapnr = env->ir[IR_V0];
@@ -130,47 +111,43 @@ void cpu_loop(CPUAlphaState *env)
abort();
case 0xAA:
/* GENTRAP */
- info.si_signo = TARGET_SIGFPE;
switch (env->ir[IR_A0]) {
case TARGET_GEN_INTOVF:
- info.si_code = TARGET_FPE_INTOVF;
+ si_code = TARGET_FPE_INTOVF;
break;
case TARGET_GEN_INTDIV:
- info.si_code = TARGET_FPE_INTDIV;
+ si_code = TARGET_FPE_INTDIV;
break;
case TARGET_GEN_FLTOVF:
- info.si_code = TARGET_FPE_FLTOVF;
+ si_code = TARGET_FPE_FLTOVF;
break;
case TARGET_GEN_FLTUND:
- info.si_code = TARGET_FPE_FLTUND;
+ si_code = TARGET_FPE_FLTUND;
break;
case TARGET_GEN_FLTINV:
- info.si_code = TARGET_FPE_FLTINV;
+ si_code = TARGET_FPE_FLTINV;
break;
case TARGET_GEN_FLTINE:
- info.si_code = TARGET_FPE_FLTRES;
+ si_code = TARGET_FPE_FLTRES;
break;
case TARGET_GEN_ROPRAND:
- info.si_code = TARGET_FPE_FLTUNK;
+ si_code = TARGET_FPE_FLTUNK;
break;
default:
- info.si_signo = TARGET_SIGTRAP;
- info.si_code = TARGET_TRAP_UNK;
- break;
+ goto do_sigtrap_unk;
}
- info.si_errno = 0;
- info._sifields._sigfault._addr = env->pc;
- queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+ force_sig_fault(TARGET_SIGFPE, si_code, env->pc);
break;
default:
goto do_sigill;
}
break;
case EXCP_DEBUG:
- info.si_signo = TARGET_SIGTRAP;
- info.si_errno = 0;
- info.si_code = TARGET_TRAP_BRKPT;
- queue_signal(env, info.si_signo, QEMU_SI_FAULT, &info);
+ do_sigtrap_brkpt:
+ force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_BRKPT, env->pc);
+ break;
+ do_sigtrap_unk:
+ force_sig_fault(TARGET_SIGTRAP, TARGET_TRAP_UNK, env->pc);
break;
case EXCP_INTERRUPT:
/* Just indicate that signals should be handled asap. */
--
2.25.1
- [PATCH v5 06/24] linux-user/hppa: Use the proper si_code for PRIV_OPR, PRIV_REG, OVERFLOW, (continued)
- [PATCH v5 06/24] linux-user/hppa: Use the proper si_code for PRIV_OPR, PRIV_REG, OVERFLOW, Richard Henderson, 2022/01/07
- [PATCH v5 05/24] linux-user/hppa: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 07/24] linux-user: Remove TARGET_NSIGFPE, Richard Henderson, 2022/01/07
- [PATCH v5 09/24] linux-user/i386: Split out maybe_handle_vm86_trap, Richard Henderson, 2022/01/07
- [PATCH v5 10/24] linux-user/i386: Use force_sig, force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 11/24] linux-user/m68k: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 15/24] linux-user/mips: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 20/24] linux-user/riscv: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 18/24] linux-user/openrisc: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 24/24] linux-user/xtensa: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 03/24] linux-user/alpha: Use force_sig_fault,
Richard Henderson <=
- [PATCH v5 16/24] target/mips: Extract break code into env->error_code, Richard Henderson, 2022/01/07
- [PATCH v5 19/24] linux-user/ppc: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 22/24] linux-user/sh4: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 23/24] linux-user/sparc: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 17/24] target/mips: Extract trap code into env->error_code, Richard Henderson, 2022/01/07
- [PATCH v5 21/24] linux-user/s390x: Use force_sig_fault, Richard Henderson, 2022/01/07
- [PATCH v5 13/24] linux-user/microblaze: Fix SIGFPE si_codes, Richard Henderson, 2022/01/07
- [PATCH v5 14/24] linux-user/mips: Improve do_break, Richard Henderson, 2022/01/07
- Re: [PATCH v5 00/24] linux-user: Clean up siginfo_t handling, Laurent Vivier, 2022/01/08