[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 29/31] linux-user: Implement CPU-specific signal handler
From: |
gaosong |
Subject: |
Re: [PATCH v11 29/31] linux-user: Implement CPU-specific signal handler for loongarch64 hosts |
Date: |
Thu, 30 Dec 2021 11:11:00 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
HI,
On 2021/12/21 下午1:41, WANG Xuerui
wrote:
+ case 0b001110: /* indexed, atomic, bounds-checking memory operations */
+ uint32_t sel = (insn >> 15) & 0b11111111111;
+
+ switch (sel) {
+ case 0b00000100000: /* stx.b */
+ case 0b00000101000: /* stx.h */
+ case 0b00000110000: /* stx.w */
+ case 0b00000111000: /* stx.d */
+ case 0b00001110000: /* fstx.s */
+ case 0b00001111000: /* fstx.d */
+ case 0b00011101100: /* fstgt.s */
+ case 0b00011101101: /* fstgt.d */
+ case 0b00011101110: /* fstle.s */
+ case 0b00011101111: /* fstle.d */
+ case 0b00011111000: /* stgt.b */
+ case 0b00011111001: /* stgt.h */
+ case 0b00011111010: /* stgt.w */
+ case 0b00011111011: /* stgt.d */
+ case 0b00011111100: /* stle.b */
+ case 0b00011111101: /* stle.h */
+ case 0b00011111110: /* stle.w */
+ case 0b00011111111: /* stle.d */
+ case 0b00011000000 ... 0b00011100011: /* am* insns */
+ return true;
+ }
+ break;
+ }
We build qemu-x86_64 on LoongArch machine, but got an error,
../linux-user/host/loongarch64/host-signal.h:57:9: error: a label can only be part of a statement and a declaration is not a statement
uint32_t sel = (insn >> 15) & 0b11111111111;
^~~~~~~~
I think we should define 'sel' before:
/* Detect store by reading the instruction at the program counter. */
switch ((insn >> 26) & 0b111111) {
or
case 0b001110:
{
uint32_t set = ...;
...
}
Thanks
Song Gao
- [PATCH v11 16/31] tcg/loongarch64: Implement shl/shr/sar/rotl/rotr ops, (continued)
- [PATCH v11 16/31] tcg/loongarch64: Implement shl/shr/sar/rotl/rotr ops, WANG Xuerui, 2021/12/21
- [PATCH v11 22/31] tcg/loongarch64: Implement simple load/store ops, WANG Xuerui, 2021/12/21
- [PATCH v11 23/31] tcg/loongarch64: Add softmmu load/store helpers, implement qemu_ld/qemu_st ops, WANG Xuerui, 2021/12/21
- [PATCH v11 28/31] common-user: Add safe syscall handling for loongarch64 hosts, WANG Xuerui, 2021/12/21
- [PATCH v11 24/31] tcg/loongarch64: Implement tcg_target_qemu_prologue, WANG Xuerui, 2021/12/21
- [PATCH v11 26/31] tcg/loongarch64: Implement tcg_target_init, WANG Xuerui, 2021/12/21
- [PATCH v11 27/31] tcg/loongarch64: Register the JIT, WANG Xuerui, 2021/12/21
- [PATCH v11 30/31] configure, meson.build: Mark support for loongarch64 hosts, WANG Xuerui, 2021/12/21
- [PATCH v11 25/31] tcg/loongarch64: Implement exit_tb/goto_tb, WANG Xuerui, 2021/12/21
- [PATCH v11 29/31] linux-user: Implement CPU-specific signal handler for loongarch64 hosts, WANG Xuerui, 2021/12/21
- Re: [PATCH v11 29/31] linux-user: Implement CPU-specific signal handler for loongarch64 hosts,
gaosong <=
- [PATCH v11 31/31] tests/docker: Add gentoo-loongarch64-cross image and run cross builds in GitLab, WANG Xuerui, 2021/12/21
- Re: [PATCH v11 00/31] LoongArch64 port of QEMU TCG, Philippe Mathieu-Daudé, 2021/12/21
- Re: [PATCH v11 00/31] LoongArch64 port of QEMU TCG, Richard Henderson, 2021/12/21