[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/17] pnv.c: simplify pnv_phb_attach_root_port()
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 05/17] pnv.c: simplify pnv_phb_attach_root_port() |
Date: |
Tue, 28 Dec 2021 16:37:54 -0300 |
The root port 'chassis' and 'slot' attributes are being set in the
realize() callback of phb3_root_port and phb4_root_port.
Remove the unneeded 'chassis' and 'slot' setting from
pnv_phb_attach_root_port().
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/pnv.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index 1bd84d20c1..605296fab5 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1222,12 +1222,10 @@ static void pnv_chip_icp_realize(Pnv8Chip *chip8, Error
**errp)
}
/* Attach a root port */
-static void pnv_phb_attach_root_port(PCIHostState *pci, int id, const char
*name)
+static void pnv_phb_attach_root_port(PCIHostState *pci, const char *name)
{
PCIDevice *root = pci_new(PCI_DEVFN(0, 0), name);
- qdev_prop_set_uint8(&root->qdev, "chassis", id);
- qdev_prop_set_uint16(&root->qdev, "slot", id);
pci_realize_and_unref(root, pci->bus, &error_fatal);
}
@@ -1326,7 +1324,7 @@ static void pnv_chip_power8_realize(DeviceState *dev,
Error **errp)
return;
}
- pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb), phb->phb_id,
+ pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb),
TYPE_PNV_PHB3_ROOT_PORT);
}
}
@@ -1506,7 +1504,7 @@ static void pnv_chip_power9_pec_realize(PnvChip *chip,
Error **errp)
for (j = 0; j < pec->num_stacks; j++) {
PnvPHB4 *phb = &pec->stacks[j].phb;
- pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb), phb->phb_id,
+ pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb),
TYPE_PNV_PHB4_ROOT_PORT);
}
}
@@ -1754,7 +1752,7 @@ static void pnv_chip_power10_phb_realize(PnvChip *chip,
Error **errp)
for (j = 0; j < pec->num_stacks; j++) {
PnvPHB4 *phb = &pec->stacks[j].phb;
- pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb), phb->phb_id,
+ pnv_phb_attach_root_port(PCI_HOST_BRIDGE(phb),
TYPE_PNV_PHB5_ROOT_PORT);
}
}
--
2.33.1
- [PATCH 00/17] ppc/pnv: enable pnv-phb4 user devices, Daniel Henrique Barboza, 2021/12/28
- [PATCH 01/17] pnv_phb3.c: add unique chassis and slot for pnv_phb3_root_port, Daniel Henrique Barboza, 2021/12/28
- [PATCH 02/17] pnv_phb3.c: do not set 'root-bus' as bus name, Daniel Henrique Barboza, 2021/12/28
- [PATCH 06/17] pnv_phb4.c: attach default root port in phb4 realize(), Daniel Henrique Barboza, 2021/12/28
- [PATCH 04/17] pnv_phb4.c: add unique chassis and slot for pnv_phb4_root_port, Daniel Henrique Barboza, 2021/12/28
- [PATCH 07/17] pnv_phb4.c: check if root port exists in rc_config functions, Daniel Henrique Barboza, 2021/12/28
- [PATCH 03/17] pnv_phb3.h: change TYPE_PNV_PHB3_ROOT_BUS name, Daniel Henrique Barboza, 2021/12/28
- [PATCH 08/17] pnv_phb4.c: introduce pnv_phb4_set_stack_phb_props(), Daniel Henrique Barboza, 2021/12/28
- [PATCH 09/17] pnv_phb4_pec.c: move pnv_pec_phb_offset() to pnv_phb4.c, Daniel Henrique Barboza, 2021/12/28
- [PATCH 05/17] pnv.c: simplify pnv_phb_attach_root_port(),
Daniel Henrique Barboza <=
- [PATCH 11/17] pnv_phb4_pec.c: use pnv_pec_get_phb_id() in pnv_pec_dt_xscom(), Daniel Henrique Barboza, 2021/12/28
- [PATCH 13/17] pnv_phb4.h: turn phb into a pointer in struct PnvPhb4PecStack, Daniel Henrique Barboza, 2021/12/28
- [PATCH 14/17] Revert "ppc/pnv: Introduce support for user created PHB4 devices", Daniel Henrique Barboza, 2021/12/28
- [PATCH 15/17] ppc/pnv: Introduce user creatable pnv-phb4 devices, Daniel Henrique Barboza, 2021/12/28
- [PATCH 10/17] pnv_phb4.c: introduce pnv_pec_init_stack_xscom(), Daniel Henrique Barboza, 2021/12/28
- [PATCH 12/17] pnv_phb4_pec.c: use 'default_enabled()' to init stack->phb, Daniel Henrique Barboza, 2021/12/28
- [PATCH 16/17] pnv_phb4.c: do not set 'root-bus' as bus name, Daniel Henrique Barboza, 2021/12/28
- [PATCH 17/17] pnv_phb4.c: change TYPE_PNV_PHB4_ROOT_BUS name, Daniel Henrique Barboza, 2021/12/28