[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 05/14] tests/unit/test-smp-parse: No need to explicitly zero M
From: |
Yanan Wang |
Subject: |
[PATCH v5 05/14] tests/unit/test-smp-parse: No need to explicitly zero MachineClass members |
Date: |
Tue, 28 Dec 2021 17:22:12 +0800 |
The default value of the MachineClass members is 0, which
means we don't have to explicitly zero them. Also the value
of "mc->smp_props.prefer_sockets" will be taken care of by
smp_parse_test(), we don't necessarily need the statement
in machine_base_class_init() either.
Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
---
tests/unit/test-smp-parse.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c
index 331719bbc4..72d83d1bbc 100644
--- a/tests/unit/test-smp-parse.c
+++ b/tests/unit/test-smp-parse.c
@@ -523,8 +523,6 @@ static void machine_base_class_init(ObjectClass *oc, void
*data)
{
MachineClass *mc = MACHINE_CLASS(oc);
- mc->smp_props.prefer_sockets = true;
-
mc->name = g_strdup(SMP_MACHINE_NAME);
}
@@ -534,9 +532,6 @@ static void machine_generic_valid_class_init(ObjectClass
*oc, void *data)
mc->min_cpus = MIN_CPUS;
mc->max_cpus = MAX_CPUS;
-
- mc->smp_props.dies_supported = false;
- mc->smp_props.clusters_supported = false;
}
static void machine_generic_invalid_class_init(ObjectClass *oc, void *data)
@@ -546,9 +541,6 @@ static void machine_generic_invalid_class_init(ObjectClass
*oc, void *data)
/* Force invalid min CPUs and max CPUs */
mc->min_cpus = 2;
mc->max_cpus = 511;
-
- mc->smp_props.dies_supported = false;
- mc->smp_props.clusters_supported = false;
}
static void machine_with_dies_class_init(ObjectClass *oc, void *data)
@@ -559,7 +551,6 @@ static void machine_with_dies_class_init(ObjectClass *oc,
void *data)
mc->max_cpus = MAX_CPUS;
mc->smp_props.dies_supported = true;
- mc->smp_props.clusters_supported = false;
}
static void machine_with_clusters_class_init(ObjectClass *oc, void *data)
@@ -570,7 +561,6 @@ static void machine_with_clusters_class_init(ObjectClass
*oc, void *data)
mc->max_cpus = MAX_CPUS;
mc->smp_props.clusters_supported = true;
- mc->smp_props.dies_supported = false;
}
static void test_generic_valid(const void *opaque)
--
2.27.0
- [PATCH v5 03/14] hw/core/machine: Wrap target specific parameters together, (continued)
- [PATCH v5 03/14] hw/core/machine: Wrap target specific parameters together, Yanan Wang, 2021/12/28
- [PATCH v5 04/14] tests/unit/test-smp-parse: Add testcases for CPU clusters, Yanan Wang, 2021/12/28
- [PATCH v5 01/14] qemu-options: Improve readability of SMP related Docs, Yanan Wang, 2021/12/28
- [PATCH v5 02/14] hw/core/machine: Introduce CPU cluster topology support, Yanan Wang, 2021/12/28
- [PATCH v5 06/14] tests/unit/test-smp-parse: Keep default MIN/MAX CPUs in machine_base_class_init, Yanan Wang, 2021/12/28
- [PATCH v5 05/14] tests/unit/test-smp-parse: No need to explicitly zero MachineClass members,
Yanan Wang <=
- [PATCH v5 08/14] hw/arm/virt: Support clusters on ARM virt machines, Yanan Wang, 2021/12/28
- [PATCH v5 07/14] MAINTAINERS: Self-recommended as reviewer of "Machine core", Yanan Wang, 2021/12/28
- [PATCH v5 09/14] hw/arm/virt: Support cluster level in DT cpu-map, Yanan Wang, 2021/12/28
- [PATCH v5 10/14] hw/acpi/aml-build: Improve scalability of PPTT generation, Yanan Wang, 2021/12/28
- [PATCH v5 11/14] hw/arm/virt-acpi-build: Make an ARM specific PPTT generator, Yanan Wang, 2021/12/28
- [PATCH v5 12/14] tests/acpi/bios-tables-test: Allow changes to virt/PPTT file, Yanan Wang, 2021/12/28
- [PATCH v5 13/14] hw/arm/virt-acpi-build: Support cluster level in PPTT generation, Yanan Wang, 2021/12/28
- [PATCH v5 14/14] tests/acpi/bios-table-test: Update expected virt/PPTT file, Yanan Wang, 2021/12/28